581850 - Stop generating 'charCode is meaningless' warnings.

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Ed Lee :Mardak]

They fill up the error console from all sorts of sites and can slow down the whole browser if you happen to have the error console open and type on certain sites like an email or chat in gmail.

Comment 1

[Boris Zbarsky [:bzbarsky]]

UI issue, not core issue, I'd think.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Well, we could give the error only once per document - the same way we warn
about boxobject usage.

Comment 3

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

I'm sure they're actually slowing us down when the console isn't open, just less so: we're still constructing and dispatching the console message.  Can we just disable the warning entirely?  It doesn't seem to be having much effect on Google Docs or Twitter, where I get the warning (twice!) for every keystroke...

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

I think we should do comment 2.

Comment 5

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

I think we should really stop emitting these.

They are triggered by libraries like jQuery.  The warning doesn't provide source coordinates, so there's no reasonable way to track them down if you suddenly see them in your app.  It hasn't motivated gmail or twitter or other sites to fix anything ever, as far as I can see.

I'm changing the title here, and I'll find someone to work up a patch.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: remove not-so-useful warnings

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Apparently I could remove ReportWrongPropertyAccessWarning.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Attachment: remove even more

Comment 9

[Nochum Sossonko [:Natch]]

I think this may have L10N impact...

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Well, some localizations may now have a string which isn't used.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Removing strings is very low impact, it's fine for that to happen after beta 7.

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/72dcbb2cb6a5