Remove nsIBaseDOMException

RESOLVED WORKSFORME

Status

()

Core
DOM
RESOLVED WORKSFORME
8 years ago
6 years ago

People

(Reporter: khuey, Assigned: Ms2ger)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 460181 [details] [diff] [review]
Patch

This appears to have fallen out of disuse sometime before we left CVS.  I didn't try too hard to track its origins down but the macros and the interface have been unused for a long time.
Attachment #460181 - Flags: review?(jst)
Comment on attachment 460181 [details] [diff] [review]
Patch

Since peterv wrote this back in the day, I'll let him decide on its faith :)
Attachment #460181 - Flags: review?(jst) → review?(peterv)
Comment on attachment 460181 [details] [diff] [review]
Patch

(In reply to comment #0)
> This appears to have fallen out of disuse sometime before we left CVS.  I
> didn't try too hard to track its origins down but the macros and the interface
> have been unused for a long time.

That's rather irrelevant because this is an API for extensions. I don't know of any users anymore, though I guess it'd be nice to at least notify about this somewhere (newsgroup post?).

>-  { &kNS_BASE_DOM_EXCEPTION_CID, false, NULL, nsBaseDOMExceptionConstructor },

You need to remove nsBaseDOMExceptionConstructor too (NS_GENERIC_FACTORY_CONSTRUCTOR(nsBaseDOMException)).
Attachment #460181 - Flags: review?(peterv) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → INCOMPLETE
(Assignee)

Comment 3

6 years ago
Created attachment 614170 [details] [diff] [review]
Patch

I want to kill this too
Assignee: khuey → Ms2ger
Attachment #460181 - Attachment is obsolete: true
Status: RESOLVED → REOPENED
Attachment #614170 - Flags: review?(peterv)
Resolution: INCOMPLETE → ---
(In reply to Ms2ger from comment #3)
> I want to kill this too

So you did notify about this somewhere? I'd rather make sure nobody uses this stuff.
Comment on attachment 614170 [details] [diff] [review]
Patch

Waiting for reply on comment 4.
Attachment #614170 - Flags: review?(peterv) → review-
(Assignee)

Comment 6

6 years ago
Looks like someone beat me to removing it.
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago6 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.