581867 - Remove nsIBaseDOMException

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

This appears to have fallen out of disuse sometime before we left CVS.  I didn't try too hard to track its origins down but the macros and the interface have been unused for a long time.

Comment 1

[Johnny Stenback (:jst)]

Comment on attachment 460181 [details] [diff] [review]
Patch

Since peterv wrote this back in the day, I'll let him decide on its faith :)

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 460181 [details] [diff] [review]
Patch

(In reply to comment #0)
> This appears to have fallen out of disuse sometime before we left CVS.  I
> didn't try too hard to track its origins down but the macros and the interface
> have been unused for a long time.

That's rather irrelevant because this is an API for extensions. I don't know of any users anymore, though I guess it'd be nice to at least notify about this somewhere (newsgroup post?).

>-  { &kNS_BASE_DOM_EXCEPTION_CID, false, NULL, nsBaseDOMExceptionConstructor },

You need to remove nsBaseDOMExceptionConstructor too (NS_GENERIC_FACTORY_CONSTRUCTOR(nsBaseDOMException)).

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch

I want to kill this too

Comment 4

[Peter Van der Beken [:peterv]]

(In reply to Ms2ger from comment #3)
> I want to kill this too

So you did notify about this somewhere? I'd rather make sure nobody uses this stuff.

Comment 5

[Peter Van der Beken [:peterv]]

Comment on attachment 614170 [details] [diff] [review]
Patch

Waiting for reply on comment 4.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Looks like someone beat me to removing it.