581881 - bug 578262 broke return value for some cross process methods.

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Oleg Romashin (:romaxa)]

Some changes from bug 578262 make some methods returning NS_ERROR_FAILURE always.
like nsFrameLoader::SendCrossProcessKeyEvent

 NS_IMETHODIMP
 nsFrameLoader::SendCrossProcessKeyEvent(const nsAString& aType,
                                         PRInt32 aKeyCode,
                                         PRInt32 aCharCode,
                                         PRInt32 aModifiers,
                                         PRBool aPreventDefault)
 {
 #ifdef MOZ_IPC
-  if (mChildProcess) {
-    mChildProcess->SendKeyEvent(aType, aKeyCode, aCharCode, aModifiers,
+  if (mRemoteBrowser) {
+    mRemoteBrowser->SendKeyEvent(aType, aKeyCode, aCharCode, aModifiers,
                                 aPreventDefault);
-    return NS_OK;
   }
 #endif
   return NS_ERROR_FAILURE;


After this change method is not returning NS_OK anymore.

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Return NS_OK, fix test-ipc.xul js errors

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 460208 [details] [diff] [review]
Return NS_OK, fix test-ipc.xul js errors

The test buttons on test-ipc.xul take these paths and confused me for a while as to the reason they were failing.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

http://hg.mozilla.org/mozilla-central/rev/c59b5292152e