bug 578262 broke return value for some cross process methods.

RESOLVED FIXED in mozilla2.0b10

Status

()

defect
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla2.0b10
x86
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [e10s])

Attachments

(1 attachment)

Assignee

Description

9 years ago
Some changes from bug 578262 make some methods returning NS_ERROR_FAILURE always.
like nsFrameLoader::SendCrossProcessKeyEvent

 NS_IMETHODIMP
 nsFrameLoader::SendCrossProcessKeyEvent(const nsAString& aType,
                                         PRInt32 aKeyCode,
                                         PRInt32 aCharCode,
                                         PRInt32 aModifiers,
                                         PRBool aPreventDefault)
 {
 #ifdef MOZ_IPC
-  if (mChildProcess) {
-    mChildProcess->SendKeyEvent(aType, aKeyCode, aCharCode, aModifiers,
+  if (mRemoteBrowser) {
+    mRemoteBrowser->SendKeyEvent(aType, aKeyCode, aCharCode, aModifiers,
                                 aPreventDefault);
-    return NS_OK;
   }
 #endif
   return NS_ERROR_FAILURE;


After this change method is not returning NS_OK anymore.
Assignee

Comment 1

9 years ago
Assignee: nobody → romaxa
Attachment #460208 - Flags: review?(benjamin)

Updated

9 years ago
Attachment #460208 - Flags: review?(benjamin) → review+
Comment on attachment 460208 [details] [diff] [review]
Return NS_OK, fix test-ipc.xul js errors

The test buttons on test-ipc.xul take these paths and confused me for a while as to the reason they were failing.
Attachment #460208 - Flags: approval2.0?

Updated

9 years ago
Attachment #460208 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/c59b5292152e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [e10s]
Target Milestone: --- → mozilla2.0b10
You need to log in before you can comment on or make changes to this bug.