Make the Save code prevent saving items that are blocked by Safe Browsing

NEW
Unassigned

Status

Camino Graveyard
Security
8 years ago
8 years ago

People

(Reporter: Smokey Ardisson (offline for a while; not following bugs - do not email), Unassigned)

Tracking

Details

(Whiteboard: p-safari, p-chrome)

From bug 581762 comment 0:

Safari, Camino and Firefox allow downloading the file from a link by right-clicking on the link and choosing 'Download linked file'/'Save link target as'/… or option-clicking the link. Google Chrome (tested: dev channel) prevents saving the link target in this case.

---

In bug 581762, we fixed the case of opt-return when the overlay was showing (which allowed people to get around our disabling of "Save"), but we still need to handle cases

1) where the user inputs the URL and opt-return in some other tab/on a page that's not blocked

2) Opt-click a link to the blocked resource

3) "Download Link Target…" on a link to the blocked resource

These all go through our Save code, which doesn't consult Safe Browsing.  (We should double-check with a binary that would trigger a download on link-click/load, too; I think that probably goes through something in Gecko that checks, but I'm not sure.)
You need to log in before you can comment on or make changes to this bug.