If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Don't pass -safeseh to ml64 because the behaviour is buggy

RESOLVED FIXED

Status

()

Core
js-ctypes
--
minor
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

Trunk
x86_64
Windows Vista
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment, 1 obsolete attachment)

4.54 KB, patch
dwitte@gmail.com
: review+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
ml64 -nologo -safeseh -c -Fosrc/x86/win64.obj src/x86/win64.asm
MASM : warning A4018: invalid command-line option : -safeseh Assembling: src/x86/win64.asm
Microsoft (R) Incremental Linker Version 8.00.50727.762
Copyright (C) Microsoft Corporation.  All rights reserved.

/OUT:win64.exe
src/x86/win64.obj
LINK : fatal error LNK1561: entry point must be defined

For some reason ml64 ignores the -c following -safeseh and tries to link.
(Assignee)

Comment 1

7 years ago
Created attachment 460215 [details] [diff] [review]
Proposed patch
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #460215 - Flags: review?(dwitte)

Comment 2

7 years ago
Comment on attachment 460215 [details] [diff] [review]
Proposed patch

r=dwitte, please also add this to js/src/ctypes/libffi.patch, and reference this bug in the description at the top. I'll push it upstream.
Attachment #460215 - Flags: superreview+

Comment 3

7 years ago
Comment on attachment 460215 [details] [diff] [review]
Proposed patch

Bugzilla from a phone is hard.
Attachment #460215 - Flags: review?(dwitte) → review+
(Assignee)

Comment 4

7 years ago
Created attachment 461004 [details] [diff] [review]
Updated for review comments
Attachment #460215 - Attachment is obsolete: true
Attachment #461004 - Flags: review?(dwitte)

Comment 5

7 years ago
Comment on attachment 461004 [details] [diff] [review]
Updated for review comments

r=dwitte, I'll push upstream and to tracemonkey. (No need to push to m-c.)
Attachment #461004 - Flags: review?(dwitte) → review+

Comment 6

7 years ago
http://hg.mozilla.org/tracemonkey/rev/6a950b735a84
Whiteboard: fixed-in-tracemonkey

Comment 7

7 years ago
http://hg.mozilla.org/mozilla-central/rev/6a950b735a84
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.