581933 - Username autocomplete doesn't work outside ASCII

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Marc Schumann [:Wurblzap]]

If I enter a string containing non-ASCII characters in a autocomplete-enabled user field, no autocomplete search results are being shown even if what I entered is a substring of some account's real name.

Search: grmblfrx
Result: Gisudf Masägrmblfrxwerz <srtfuiawe@...>

Search: ägrmblfrx
Result: -none-

Can be reproduced on landfill.

Comment 1

[Max Kanat-Alexander]

For now, this is blocking 4.0, so that we can investigate it. However, I have a suspicion that this may be due to the UTF-8 behavior of JSON-RPC. If it is, it will probably be pretty tricky to fix. But it may still be fixable. If it isn't fixable for 4.0, then moving to RPC::Any will fix it, because I know that RPC::Any has working Unicode behavior.

Comment 2

[Max Kanat-Alexander]

Okay, I've confirmed this on the bugzilla-tip installation, and will be investigating the cause.

Comment 3

[Max Kanat-Alexander]

Okay, the problem is in our JavaScript. We're getting enteredText as a URL-escaped value, and when we do unescape on it, it becomes latin1 instead of UTF-8. We need to find out how to get the data out of the field without it becoming pre-escaped.

Comment 4

[Max Kanat-Alexander]

Attachment: v1

Turns out that the fix is really easy! We just have to use decodeURIComponent instead of unescape. For more info about the difference, see:

  http://xkr.us/articles/javascript/encode-compare/

Also, that other line of code didn't need the unescape--it wasn't getting URI-escaped data.

Comment 5

[Marc Schumann [:Wurblzap]]

Comment on attachment 485454 [details] [diff] [review]
v1

Thanks, works as advertised :)

Comment 6

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified js/field.js
Committed revision 7576.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.0/                         
modified js/field.js
Committed revision 7462