581947 - Show validation message error in the tooltip of an invalid element

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Mounir Lamouri (:mounir)]

This is needed for bug 561636: when an element is invalid (and not barred from constraint validation), its tooltip should show the validation message error (element.validationMessage).

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 460258 [details] [diff] [review]
Patch v1

This should probably get ui-review.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Then we should get a screenshot showing what it looks like!

Comment 4

[Mounir Lamouri (:mounir)]

Attachment: Screenshot

Here is a screenshot :)

Comment 5

[Mounir Lamouri (:mounir)]

(In reply to comment #4)
> Created attachment 460564 [details]
> Screenshot
> 
> Here is a screenshot :)

The mouse pointer isn't visible so you have to believe the mouse was hovering the textfield ;)

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 460258 [details] [diff] [review]
Patch v1

>@@ -1098,16 +1099,25 @@ DefaultTooltipTextProvider::GetNodeText(
>   NS_ENSURE_ARG_POINTER(aNode);
>   NS_ENSURE_ARG_POINTER(aText);
>     
>   nsString outText;
> 
>   PRBool lookingForSVGTitle = PR_TRUE;
>   PRBool found = PR_FALSE;
>   nsCOMPtr<nsIDOMNode> current ( aNode );
>+
>+  // If the element implement the constraint validation API,
>+  // show the validation message, if any, instead of the title.
>+  nsCOMPtr<nsIConstraintValidation> cvElement (do_QueryInterface(current));

Personally I prefer

nsCOMPtr<nsIConstraintValidation> cvElement = do_QueryInterface(current);

since I find it more readable, and it means the same thing in C++. I.e. it directly runs the nsCOMPtr ctor with the return value from do_QI. (weird quirk inherited from C).

Comment 7

[Alex Limi (:limi) — Firefox UX Team]

Comment on attachment 460258 [details] [diff] [review]
Patch v1

Looks good to me from the screenshot, is there a tryserver build where I can test the flow of this when it's actually used? Alternatively, find me in the office since you're here, and walk me through it? There might be some interaction things that I can't read out of a screenshot we might want adjust. But generally, it looks good. :)

Comment 8

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/6a95227f6b07