Closed
Bug 582032
Opened 11 years ago
Closed 11 years ago
Pre-launch content process
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(blocking2.0 final+)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
blocking2.0 | --- | final+ |
People
(Reporter: cjones, Assigned: dougt)
References
Details
(Keywords: perf)
Attachments
(1 file, 4 obsolete files)
2.97 KB,
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
While debugging last week, I noticed that when fennec boots into its home screen, it doesn't load the content process in the background. This puts content-process startup on the critical path to load the first web page. We should instead launch the content process in the background after the home screen displays (from onload or something like that ?). This may or may not help with bug 581930.
Updated•11 years ago
|
blocking2.0: --- → final+
Comment 1•11 years ago
|
||
Add a scriptable method to nsIXULRuntime? Then the front-end can startup the child process whenever is convenient.
Assignee | ||
Comment 2•11 years ago
|
||
Assignee: nobody → doug.turner
Attachment #461581 -
Flags: review?
Assignee | ||
Updated•11 years ago
|
Attachment #461581 -
Attachment is patch: true
Attachment #461581 -
Attachment mime type: application/octet-stream → text/plain
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 461581 [details] [diff] [review] patch v.1 (adding a start method to nsIXULRuntime.idl) (excuse the style on declaring ContentChild)
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #461581 -
Attachment is obsolete: true
Attachment #461587 -
Flags: review?
Attachment #461581 -
Flags: review?
Assignee | ||
Comment 5•11 years ago
|
||
Attachment #461605 -
Flags: review?(mark.finkle)
Assignee | ||
Updated•11 years ago
|
Attachment #461587 -
Flags: review? → review?(jones.chris.g)
Updated•11 years ago
|
Attachment #461605 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #461587 -
Attachment is obsolete: true
Attachment #461610 -
Flags: review?
Attachment #461587 -
Flags: review?(jones.chris.g)
Reporter | ||
Comment 7•11 years ago
|
||
Comment on attachment 461610 [details] [diff] [review] patch v.3 (adding a start method to nsIXULRuntime.idl) >diff --git a/xpcom/system/nsIXULRuntime.idl b/xpcom/system/nsIXULRuntime.idl >--- a/xpcom/system/nsIXULRuntime.idl >+++ b/xpcom/system/nsIXULRuntime.idl >@@ -102,9 +102,18 @@ interface nsIXULRuntime : nsISupports > readonly attribute unsigned long processType; > > /** > * Signal the apprunner to invalidate caches on the next restart. > * This will cause components to be autoregistered and all > * fastload data to be re-created. > */ > void invalidateCachesOnRestart(); >+ >+ /** >+ * Starts a child process. This method is intented to pre-start a >+ * child process so that when it is actually needed, it is ready to >+ * go. >+ * >+ * @throw NS_ERROR_NOT_AVAILABLE if not available. >+ */ >+ void startProcess(in unsigned long processType); > }; Nit: please change the name of |startProcess()| to match your comment, to maybe |ensureProcessStarted()|.
Attachment #461610 -
Flags: review? → review+
Comment 8•11 years ago
|
||
I think this is too generic, can it just be ensureContentProcess() ? This API doesn't make sense for jetpack or plugin processes, which are initialized with specific data and aren't singletons.
Comment 9•11 years ago
|
||
(In reply to comment #8) > I think this is too generic, can it just be ensureContentProcess() ? This API > doesn't make sense for jetpack or plugin processes, which are initialized with > specific data and aren't singletons. ensureContentProcess() sounds fine to me
Assignee | ||
Comment 10•11 years ago
|
||
bsmedberg is probably right... make it specific, and change it if we need it to do more.
Attachment #461605 -
Attachment is obsolete: true
Attachment #461610 -
Attachment is obsolete: true
Attachment #461615 -
Flags: review?
Assignee | ||
Updated•11 years ago
|
Attachment #461615 -
Attachment is patch: true
Attachment #461615 -
Attachment mime type: application/octet-stream → text/plain
Attachment #461615 -
Flags: review? → review?(chris.jones)
Reporter | ||
Comment 11•11 years ago
|
||
Comment on attachment 461615 [details] [diff] [review] patch v.4 (adding a start method to nsIXULRuntime.idl) Suits me.
Attachment #461615 -
Flags: review?(chris.jones) → review+
Assignee | ||
Comment 12•11 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/f1fa3a946466 http://hg.mozilla.org/mobile-browser/rev/d7a87c2b3102
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 13•11 years ago
|
||
I checked in a follow-up bustage fix for non-ipc builds: http://hg.mozilla.org/mozilla-central/rev/39ffc0a802e6
Comment 14•11 years ago
|
||
Going to mark this verified as we are top websites seem to be loading fine now. Startup performance is still an issue, but that's tracked elsewhere. Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:2.0b4pre) Gecko/20100820 Namoroka/4.04pre Fennec/2.0a1pre
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•