If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

nanojit: fix formatImm[IQ] bogons

RESOLVED FIXED

Status

Core Graveyard
Nanojit
RESOLVED FIXED
7 years ago
4 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-nanojit, fixed-in-tamarin, fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 460481 [details] [diff] [review]
patch (against TM 48065:7ff4f93bddaa)

Small integer immediates, in the range -9999..9999, are printed specially by Nanojit in the LIR dumping stages.  Except the ranges tests are broken, using '||' where they should use '&&'.  Because of this I was seeing the 64-bit immediate 0x7fffffffffff printed as -1, because it was being cast to 'int'.

The attached patch fixes this.  It also changes formatImmQ() to be defined only on 64-bit platforms.
Attachment #460481 - Flags: review?(edwsmith)

Updated

7 years ago
Attachment #460481 - Flags: review?(edwsmith) → review+
(Assignee)

Comment 1

7 years ago
http://hg.mozilla.org/projects/nanojit-central/rev/ce704edcab9d
Whiteboard: fixed-in-nanojit

Comment 2

7 years ago
TR: http://hg.mozilla.org/tamarin-redux/rev/be8ddbd17a5f
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tamarin
(Assignee)

Comment 3

7 years ago
http://hg.mozilla.org/tracemonkey/rev/ea977d4cd722
Whiteboard: fixed-in-nanojit, fixed-in-tamarin → fixed-in-nanojit, fixed-in-tamarin, fixed-in-tracemonkey

Comment 4

7 years ago
http://hg.mozilla.org/mozilla-central/rev/ea977d4cd722
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Component: Nanojit → Nanojit
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.