Closed Bug 582239 Opened 12 years ago Closed 12 years ago

Add "delete file" function to download manager

Categories

(Firefox for Android Graveyard :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: isandu, Assigned: wesj)

Details

Attachments

(1 file, 1 obsolete file)

Can we have a button in the Downloads manager to delete a downloaded file, next to the Open and Remove buttons?
Severity: normal → enhancement
Attached patch simple fix (obsolete) — Splinter Review
This changes the behavior of the remove button to delete+remove if it can. It also hides buttons that are disabled.
Attachment #474141 - Flags: review?(mark.finkle)
Comment on attachment 474141 [details] [diff] [review]
simple fix

I am ok withthe remove+delete part, but not so much with the disable->hide change for the buttons.

Also, if we did want to keep the disable->hide, we wouldn't do it this way. I'd remove the code to disable in the first place and hide if the referrer is missing.

Also, the .show-on-select CSS rules are already here:
http://mxr.mozilla.org/mobile-browser/source/themes/core/platform.css#576

r-, let's just do the remove+delete
Attachment #474141 - Flags: review?(mark.finkle) → review-
if we want the visibility of disabled buttons to change, it's a bigger bug (more than downloads) and a separate bug
Attached patch even simpler fixSplinter Review
Sounds fine to me. Here's just the delete part.
Attachment #474141 - Attachment is obsolete: true
Attachment #474198 - Flags: review?(mark.finkle)
Attachment #474198 - Flags: review?(mark.finkle) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/3d3e6ddc0ccd
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
bugspam
Assignee: nobody → wjohnston
Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110920
Firefox/9.0a1 Fennec/9.0a1
Device: Samsung Galaxy S
OS: Android 2.2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.