582239 - Add "delete file" function to download manager

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Irina Sandu]

Can we have a button in the Downloads manager to delete a downloaded file, next to the Open and Remove buttons?

Comment 1

[Wesley Johnston (:wesj)]

Attachment: simple fix

This changes the behavior of the remove button to delete+remove if it can. It also hides buttons that are disabled.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 474141 [details] [diff] [review]
simple fix

I am ok withthe remove+delete part, but not so much with the disable->hide change for the buttons.

Also, if we did want to keep the disable->hide, we wouldn't do it this way. I'd remove the code to disable in the first place and hide if the referrer is missing.

Also, the .show-on-select CSS rules are already here:
http://mxr.mozilla.org/mobile-browser/source/themes/core/platform.css#576

r-, let's just do the remove+delete

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

if we want the visibility of disabled buttons to change, it's a bigger bug (more than downloads) and a separate bug

Comment 4

[Wesley Johnston (:wesj)]

Attachment: even simpler fix

Sounds fine to me. Here's just the delete part.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/3d3e6ddc0ccd

Comment 6

[Dão Gottwald [:dao]]

bugspam

Comment 7

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110920
Firefox/9.0a1 Fennec/9.0a1
Device: Samsung Galaxy S
OS: Android 2.2