Clusters should not be part of the feedback Django app

RESOLVED FIXED in 1.7

Status

Input
General
P1
normal
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: wenzel, Assigned: davedash)

Tracking

Details

(Whiteboard: [qa-])

(Reporter)

Description

8 years ago
apps/feedback contains (mostly) stuff related to collecting feedback. Clustering has nothing to do with collecting feedback, and should probably be its own Django app.
Fair point, it's kind of grown.  Originally it was a cluster of opinions which is why I started there.
Will this help us in terms of performance?
Priority: -- → P2
Target Milestone: --- → 1.7
(Reporter)

Comment 3

7 years ago
Ryan: I think this would help you figuring out Django. What we need here is a new app under apps, named clusters. Then move all things related to the clusters part of the site (url rules, views, possibly helpers, as well as models and templates) from the feedback app to the clusters app. Presumably a few imports will need to change, and for the models, you'll have to define the Meta option [1] db_table (because the tables already exist and they are prefixed with feedback_ ).

As this -- to answer Aakash's question -- won't have a performance impact, this is also not vital for 1.7, so you can take it easy.

[1] http://docs.djangoproject.com/en/dev/ref/models/options/
Priority: P2 → P3
Uh... ryan if you do this, have me r? it.  I created in a branch an app called "topics" and was doing the same thing.  If you don't get to it by monday I will actually do this, as I need to redo the topics UX (and underlying models).
Thanks Fred.  

No worries Dave.  If you're already working on this, then don't let me get in your way.
Assignee: nobody → dd
Blocks: 586925
Priority: P3 → P1
http://github.com/fwenzel/reporter/commits/02eda48
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Is this something QA can verify?
Whiteboard: [qa-]
Component: Input → General
Product: Webtools → Input
You need to log in before you can comment on or make changes to this bug.