582288 - Clusters should not be part of the feedback Django app

Status: RESOLVED FIXED

(Input :: General, defect, P1)

Description

[Fred Wenzel [:wenzel]]

apps/feedback contains (mostly) stuff related to collecting feedback. Clustering has nothing to do with collecting feedback, and should probably be its own Django app.

Comment 1

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Fair point, it's kind of grown.  Originally it was a cluster of opinions which is why I started there.

Comment 2

[Aakash Desai [:aakashd]]

Will this help us in terms of performance?

Comment 3

[Fred Wenzel [:wenzel]]

Ryan: I think this would help you figuring out Django. What we need here is a new app under apps, named clusters. Then move all things related to the clusters part of the site (url rules, views, possibly helpers, as well as models and templates) from the feedback app to the clusters app. Presumably a few imports will need to change, and for the models, you'll have to define the Meta option [1] db_table (because the tables already exist and they are prefixed with feedback_ ).

As this -- to answer Aakash's question -- won't have a performance impact, this is also not vital for 1.7, so you can take it easy.

[1] http://docs.djangoproject.com/en/dev/ref/models/options/

Comment 4

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Uh... ryan if you do this, have me r? it.  I created in a branch an app called "topics" and was doing the same thing.  If you don't get to it by monday I will actually do this, as I need to redo the topics UX (and underlying models).

Comment 5

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Thanks Fred.  

No worries Dave.  If you're already working on this, then don't let me get in your way.

Comment 6

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

http://github.com/fwenzel/reporter/commits/02eda48

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Is this something QA can verify?