Closed Bug 582303 Opened 10 years ago Closed 10 years ago

remove unneeded nsIDOMNSHTML*Element interfaces

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b4

People

(Reporter: dzbarsky, Assigned: dzbarsky)

References

Details

Attachments

(13 files, 6 obsolete files)

8.56 KB, patch
jst
: review+
Details | Diff | Splinter Review
10.09 KB, patch
jst
: review+
Details | Diff | Splinter Review
12.50 KB, patch
jst
: review+
Details | Diff | Splinter Review
9.54 KB, patch
Details | Diff | Splinter Review
10.74 KB, patch
Details | Diff | Splinter Review
14.04 KB, patch
Details | Diff | Splinter Review
59.33 KB, patch
beltzner
: approval2.0+
Details | Diff | Splinter Review
15.46 KB, patch
jst
: review+
Details | Diff | Splinter Review
11.52 KB, patch
jst
: review+
Details | Diff | Splinter Review
38.55 KB, patch
jst
: review+
Details | Diff | Splinter Review
15.58 KB, patch
Details | Diff | Splinter Review
11.52 KB, patch
Details | Diff | Splinter Review
40.97 KB, patch
Details | Diff | Splinter Review
No description provided.
Assignee: nobody → dzbarsky
Attached patch kill Label (obsolete) — Splinter Review
Attachment #460578 - Flags: review?(jst)
Summary: remove unneeded nsIDOMHTMLNS*Element interfaces → remove unneeded nsIDOMNSHTML*Element interfaces
Attached patch abolish ScriptSplinter Review
Attachment #460579 - Flags: review?(jst)
Attached patch uproot Select (obsolete) — Splinter Review
Attachment #460580 - Flags: review?(jst)
Attached patch oust Option (obsolete) — Splinter Review
Attachment #460581 - Flags: review?(jst)
Attachment #460613 - Flags: review?(jst)
Attached patch Obliterate areaSplinter Review
Attachment #460614 - Flags: review?(jst)
Attached patch uproot Select (obsolete) — Splinter Review
typo the first time
Attachment #460580 - Attachment is obsolete: true
Attachment #460615 - Flags: review?(jst)
Attachment #460580 - Flags: review?(jst)
OS: Windows XP → All
Hardware: x86 → All
Blocks: 582412
Attachment #460578 - Flags: review?(jst) → review+
Attachment #460579 - Flags: review?(jst) → review+
Attachment #460581 - Flags: review?(jst) → review+
Attachment #460613 - Flags: review?(jst) → review+
Attachment #460614 - Flags: review?(jst) → review+
Comment on attachment 460615 [details] [diff] [review]
uproot Select

 interface nsIDOMHTMLSelectElement : nsIDOMHTMLElement
 {
+           attribute boolean               autofocus;
   readonly attribute DOMString             type;
            attribute long                  selectedIndex;
            attribute DOMString             value;
   // Modified in DOM Level 2:
            attribute unsigned long         length;
                                              // raises(DOMException) on setting
 
+  nsIDOMNode                item(in unsigned long index);
+  nsIDOMNode                namedItem(in DOMString name);
+
   readonly attribute nsIDOMHTMLFormElement form;
   // Modified in DOM Level 2:
   readonly attribute nsIDOMHTMLOptionsCollection options;
            attribute boolean               disabled;
            attribute boolean               multiple;
            attribute DOMString             name;
            attribute long                  size;
            attribute long                  tabIndex;

While we're making a binary incompatible change here, want to re-order the attributes/methods here to match the order in the HTML5 spec? And remove the comments about modified in DOM Level 2 please.

r=jst
Attachment #460615 - Flags: review?(jst) → review+
Sure, I was doing that anyways but maybe I missed some.
Attachment #460578 - Attachment is obsolete: true
Attachment #460581 - Attachment is obsolete: true
Attachment #460615 - Attachment is obsolete: true
Whiteboard: checkin-needed
Keywords: checkin-needed
Attachment #460911 - Flags: approval2.0?
Comment on attachment 460911 [details] [diff] [review]
Combined monster patch

a=beltzner - you can land these as individual patches, or the monster patch, up to you! :)
Attachment #460911 - Flags: approval2.0? → approval2.0+
I'll land these later today, once they clear try.
Keywords: checkin-needed
Whiteboard: checkin-needed
Also, I noticed you missed regenerating one of the IIDs:
http://hg.mozilla.org/mozilla-central/rev/c6673716fd47

Also, note the commit messages I used; they may be useful for learning how to write good commit messages.  (In the future, From: lines and commit messages are good to include in patches.  You can make mq generate the From: lines automatically, too.)  (At some point I'll write a blog entry about writing good commit messages.  I think I have a half-written one somewhere.)
Gah sorry. Thanks for taking the time to fix this and land it.  I'm gonna keep it open because I've done about half and I'm gonna finish the rest.
Ah thank you.  I never would have found that with my search.
Attachment #460579 - Attachment is obsolete: true
Attachment #460579 - Flags: superreview+
Attachment #460911 - Attachment is obsolete: true
Attachment #460579 - Attachment is obsolete: false
Attachment #460579 - Flags: superreview+
Attachment #460911 - Attachment is obsolete: false
Attached patch Eradicate anchorSplinter Review
Attachment #461461 - Flags: review?(jst)
Attached patch Expunge imageSplinter Review
Attachment #461462 - Flags: review?(jst)
Attached patch Amputate inputSplinter Review
Attachment #461463 - Flags: review?(jst)
Attachment #461461 - Flags: review?(jst)
Attachment #461461 - Flags: review+
Attachment #461461 - Flags: approval2.0+
Attachment #461462 - Flags: review?(jst)
Attachment #461462 - Flags: review+
Attachment #461462 - Flags: approval2.0+
Attachment #461463 - Flags: review?(jst)
Attachment #461463 - Flags: review+
Attachment #461463 - Flags: approval2.0+
Keywords: checkin-needed
Attached patch anchor, update to tip (obsolete) — Splinter Review
Attached patch input, updated to tip (obsolete) — Splinter Review
Attachment #461977 - Attachment is obsolete: true
Attachment #461978 - Attachment is obsolete: true
Attached patch image refreshSplinter Review
Attached patch input refreshSplinter Review
Pushed:
  http://hg.mozilla.org/mozilla-central/rev/6690d31dbdaa
  http://hg.mozilla.org/mozilla-central/rev/5bb0dd9b0192
  http://hg.mozilla.org/mozilla-central/rev/a7a5db113414

and then:

  http://hg.mozilla.org/mozilla-central/rev/a8563385a1e3
  http://hg.mozilla.org/mozilla-central/rev/cae29488f632

to fix build bustage due to CRs in the idl.  Apparently the spec has those in some places in the IDL, but not consistently, yay.  And then:

  http://hg.mozilla.org/mozilla-central/rev/09ab37b7d558

to fix an issue compiling nsHTMLFormControlAccessible.cpp (nsIDOMNSHTMLElement was replaced by nsIDOMHTMLElement).
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
Keywords: checkin-needed
(In reply to comment #31)
> This seems to have caused the Thunderbird and SeaMonkey tinderboxes to catch
> fire.

The bustage was a result of knock-on changes being required in comm-central. I have fixed those now and we should be back to green soon.
You need to log in before you can comment on or make changes to this bug.