58233 - SeaMonkey should support downloading CRL's

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P3)

Description

[Javier Delgadillo]

SeaMonkey does not have a mechanism to import CRL's into the broswer.  We should
look to add this functionality in a future release.

Comment 1

[nitinp]

changing QA contact to [e-mail]

Comment 2

[Bob Lord]

We need some good test cases for this feature.

Comment 3

[David P. Drinan]

Attachment: Patch to download and manage CRLs.

Comment 4

[David P. Drinan]

Javi, please review.

Comment 5

[Javier Delgadillo]

If you're not going to use a default constructor for nsCrlEntry, then I wouldn't
bother defining the empty constructor.

I think the interface for deleteCRL would be cleaner if you passed in a
nsICrEntry instead of an index.  It's not immediately obvious what the index
refers to.  It apears that it's the index in the nsISupportsArray that gets
returned, but that's not obvious from the idl definition.  Comments stating what
the index refers would suffice as well.

These are take it or leave it comments.

r=javi

Comment 6

[David P. Drinan]

I'll add comments to the idl describing what the index means.

Adding blizzard to cc-list.

Chris,

Please super-review.

Thanks,
David.

Comment 7

[Christopher Blizzard (:blizzard)]

+  // document.getElementById("updateCrl").removeAttribute("disabled", "true");

eh?  Why is that commented out?

+  case PSMContentDownloader::PKCS7_CRL:
+    return certdb->ImportCrl(mByteData, mBufferOffset, mURI, SEC_CRL_TYPE);
   default:
 	  rv = NS_ERROR_FAILURE;
 	  break;

you might want to add a break there anyway just for clarity.

Those are just suggestions.  Take 'em or leave 'em.  Other than that sr=blizzard

Comment 8

[Bob Lord]

ddrinan:  Please post detailed instructions here for those of us around the
world who want to QA this feature.  

Comment 9

[David P. Drinan]

Fixed in PSM 2.0

Comment 10

[John Unruh]

Verified.