Vector tests need additional test cases to improve coverage

VERIFIED FIXED in Q3 11 - Serrano

Status

Tamarin
Tools
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: Chris Peyer, Assigned: Chris Peyer)

Tracking

(Blocks: 1 bug)

unspecified
Q3 11 - Serrano
x86
Windows 7
Bug Flags:
flashplayer-qrb +
flashplayer-triage +

Details

(Whiteboard: code-coverage)

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Current vector coverage numbers:

(all regions with 'vector')
Function Coverage: 72%
Uncovered Functions: 36
Conditional Coverage: 68%
Uncovered Conditions: 76

Also - just perusing the vector tests, most only test <int> vectors and many of the tests do not test all conditions.
Flags: flashplayer-qrb?
(Assignee)

Comment 1

8 years ago
Created attachment 464681 [details] [diff] [review]
Increase vector coverage

This patch (plus changes by lars in Bug 584318) increase coverage to:

Function: 91% 16 uncovered
Condition: 77%
Attachment #464681 - Flags: review?(brbaker)
(Assignee)

Comment 2

8 years ago
fyi - The majority of uncovered conditions are throwArgumentError branches.

Overall coverage can be seen here: http://asteam.macromedia.com/builds/downloads/cpeyer/vectorCoverage.html

The coverage file is also in that directory.
OS: Mac OS X → Windows 7

Updated

8 years ago
Whiteboard: code-coverage

Comment 3

8 years ago
Adding Lars and Erik to help out.

Updated

8 years ago
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
Flags: flashplayer-qrb+

Updated

8 years ago
Target Milestone: --- → flash10.2
(Assignee)

Comment 4

8 years ago
Comment on attachment 464681 [details] [diff] [review]
Increase vector coverage

Got the r+ via im.
Attachment #464681 - Flags: review?(brbaker) → review+
(Assignee)

Comment 5

8 years ago
Pushed to redux:

http://hg.mozilla.org/tamarin-redux/rev/6f3032b992e8
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.