Closed
Bug 582393
Opened 14 years ago
Closed 14 years ago
Vector tests need additional test cases to improve coverage
Categories
(Tamarin Graveyard :: Tools, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Q3 11 - Serrano
People
(Reporter: cpeyer, Assigned: cpeyer)
References
Details
(Whiteboard: code-coverage)
Attachments
(1 file)
|
16.56 KB,
patch
|
cpeyer
:
review+
|
Details | Diff | Splinter Review |
Current vector coverage numbers:
(all regions with 'vector')
Function Coverage: 72%
Uncovered Functions: 36
Conditional Coverage: 68%
Uncovered Conditions: 76
Also - just perusing the vector tests, most only test <int> vectors and many of the tests do not test all conditions.
Flags: flashplayer-qrb?
|
Assignee | |
Comment 1•14 years ago
|
||
This patch (plus changes by lars in Bug 584318) increase coverage to:
Function: 91% 16 uncovered
Condition: 77%
Attachment #464681 -
Flags: review?(brbaker)
|
|
Assignee | |
Comment 2•14 years ago
|
||
fyi - The majority of uncovered conditions are throwArgumentError branches.
Overall coverage can be seen here: http://asteam.macromedia.com/builds/downloads/cpeyer/vectorCoverage.html
The coverage file is also in that directory.
OS: Mac OS X → Windows 7
|
||
Updated•14 years ago
|
Whiteboard: code-coverage
|
|
||
Comment 3•14 years ago
|
||
Adding Lars and Erik to help out.
|
|
||
Updated•14 years ago
|
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
Flags: flashplayer-qrb+
|
|
||
Updated•14 years ago
|
Target Milestone: --- → flash10.2
|
|
Assignee | |
Comment 4•14 years ago
|
||
Comment on attachment 464681 [details] [diff] [review]
Increase vector coverage
Got the r+ via im.
Attachment #464681 -
Flags: review?(brbaker) → review+
|
|
Assignee | |
Comment 5•14 years ago
|
||
Pushed to redux:
http://hg.mozilla.org/tamarin-redux/rev/6f3032b992e8
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•14 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•