582419 - JM: jsreftest failure on js1_8_1\regress\regress-479430-01.js

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Mandelin [:dmandelin]]

Also affects the -02 and -04 "subtests". I believe the issue is with triggering the operationCallback in the presence of infinite recursion. Here is a reduced test case:

  timeout(1);
  function f(n) {
    if (!n)
	return;
    f(n-1);
    f(n-1);
  }
  f(100);
  print('done')

This should terminate after one second, but it doesn't with -m. The timeout fires, but execution doesn't stop. We are probably missing operationCallback checks in function entry or exit that would catch this.

Comment 1

[Andrew Drake [:adrake]]

There should be callback checks on function calls. Patch forthcoming...

Comment 2

[Andrew Drake [:adrake]]

Attachment: Patch v0

Moves interrupt check into a helper function and calls it from the top of JSOP_CALL/NEW/etc in addition to its previous location of JSOP_TRACE.

Comment 3

[David Mandelin [:dmandelin]]

Comment on attachment 460704 [details] [diff] [review]
Patch v0

Looks great. Thanks!

Comment 4

[Andrew Drake [:adrake]]

http://hg.mozilla.org/users/danderson_mozilla.com/moo/rev/c893f830ff7e