Closed Bug 582463 Opened 10 years ago Closed 4 years ago

Places spends a large amount of time in MatchAutoCompleteFunction::OnFunctionCall()

Categories

(Toolkit :: Places, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: jrmuizel, Unassigned)

Details

On startup after I start typing in URL bar and places seems to spend a very large amount of time hanging my browser.

I profiled it and 90% of the time was in sqlite3_step under which we spent 50% of the time in MatchAutoCompleteFunction.
Note: it's highly unlikely that you are hanging in that seeing as how it's not running on the main thread.  I should maybe add some assertions just to make sure about that though...
It's true, the time was not being spent on the main thread. Perhaps something on the main thread is waiting for something on the storage thread to complete?
We've had a few of these bugs crop up recently, so possible :/
As an aside, do we have any way of exposing performance information on what sqlite is doing. i.e. statistics on how often we hit and miss in the page cache. I often see sqlite3_step etc. show up in profiles but it's hard to do much with the results or to tell how efficient sqlite is being.
Not that I am aware of.
not actionable. We are moving more and more to the async thread, so it should slowly improve along the way, but there' still work to do.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.