582521 - Latest tracemonkey breaks some assignments to char characters on idl interfaces

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Mark Banner (:standard8)]

sayre mentioned to me that tracemonkey is doing another merge to trunk very soon. I therefore checked it out with comm-central and latest tracemonkey (revision d7c7ba27b84e), and built and ran the Thunderbird tests.

Some of the our xpcshell-tests are broken with the following error:

TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | [Exception... "Could not convert JavaScript argument arg 0 [nsIMsgImapMailFolder.hierarchyDelimiter]"  nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"

This seems like a regression. nsIMsgImapFolder has defined:

attribute char hierarchyDelimiter;

and the tests that are failing have:

msgImapFolder.hierarchyDelimiter = '/';

FTR some of the failing tests with this message are:
test_imapUndo.js
test_listClosesDB.js
test_imapFolderCopy.js
test_imapFilterActions.js
test_copyThenMove.js

Comment 1

[Boris Zbarsky [:bzbarsky]]

Is that in a debug build only?  The patch for bug 573841 added a bogus |return JS_FALSE| in the nsXPTType::T_CHAR case in JSData2Native that only gets triggered in debug builds... but will reliably fail conversion of strings to chars in debug builds.

Comment 2

[[e-mail]]

Guh!! I am shocked, shocked that we have no test in m-c that tickled this.

I'm out of town atm but I'll try to patch later today. If anyone wants to preempt, though...

Comment 3

[[e-mail]]

Attachment: patch

bz, want to stamp this? mrbkap's at BH this week.

I'm going to write a test for this, but I'm at BH too, so I'll follow up when I get back.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 460932 [details] [diff] [review]
patch

r=me

Comment 5

[[e-mail]]

Comment on attachment 460932 [details] [diff] [review]
patch

Definitely want this in tm ASAP.

Comment 6

[Boris Zbarsky [:bzbarsky]]

It's already a blocker; just land it.

Comment 7

[[e-mail]]

http://hg.mozilla.org/tracemonkey/rev/1f3358bd4ef4

Comment 8

[Mark Banner (:standard8)]

FWIW I've just applied this to the same tracemonkey build as I had earlier and it works fine.

Thanks everyone.

Comment 9

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/1f3358bd4ef4