Latest tracemonkey breaks some assignments to char characters on idl interfaces

RESOLVED FIXED

Status

()

Core
XPConnect
--
major
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: standard8, Assigned: dwitte@gmail.com)

Tracking

({regression})

Trunk
All
Mac OS X
regression
Points:
---

Firefox Tracking Flags

(blocking2.0 betaN+)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
sayre mentioned to me that tracemonkey is doing another merge to trunk very soon. I therefore checked it out with comm-central and latest tracemonkey (revision d7c7ba27b84e), and built and ran the Thunderbird tests.

Some of the our xpcshell-tests are broken with the following error:

TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | [Exception... "Could not convert JavaScript argument arg 0 [nsIMsgImapMailFolder.hierarchyDelimiter]"  nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"

This seems like a regression. nsIMsgImapFolder has defined:

attribute char hierarchyDelimiter;

and the tests that are failing have:

msgImapFolder.hierarchyDelimiter = '/';

FTR some of the failing tests with this message are:
test_imapUndo.js
test_listClosesDB.js
test_imapFolderCopy.js
test_imapFilterActions.js
test_copyThenMove.js
Is that in a debug build only?  The patch for bug 573841 added a bogus |return JS_FALSE| in the nsXPTType::T_CHAR case in JSData2Native that only gets triggered in debug builds... but will reliably fail conversion of strings to chars in debug builds.
Assignee: general → nobody
Blocks: 573841
blocking2.0: --- → ?
Component: JavaScript Engine → XPConnect
QA Contact: general → xpconnect
(Assignee)

Comment 2

8 years ago
Guh!! I am shocked, shocked that we have no test in m-c that tickled this.

I'm out of town atm but I'll try to patch later today. If anyone wants to preempt, though...
(Assignee)

Comment 3

8 years ago
Created attachment 460932 [details] [diff] [review]
patch

bz, want to stamp this? mrbkap's at BH this week.

I'm going to write a test for this, but I'm at BH too, so I'll follow up when I get back.
Assignee: nobody → dwitte
Status: NEW → ASSIGNED
Attachment #460932 - Flags: review?(bzbarsky)
Comment on attachment 460932 [details] [diff] [review]
patch

r=me
Attachment #460932 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 5

8 years ago
Comment on attachment 460932 [details] [diff] [review]
patch

Definitely want this in tm ASAP.
Attachment #460932 - Flags: approval2.0?

Updated

8 years ago
Attachment #460932 - Flags: approval2.0? → approval2.0+

Updated

8 years ago
blocking2.0: ? → betaN+
It's already a blocker; just land it.
(Assignee)

Comment 7

8 years ago
http://hg.mozilla.org/tracemonkey/rev/1f3358bd4ef4
blocking2.0: betaN+ → ?
Whiteboard: fixed-in-tracemonkey
(Reporter)

Comment 8

8 years ago
FWIW I've just applied this to the same tracemonkey build as I had earlier and it works fine.

Thanks everyone.
blocking2.0: ? → betaN+

Comment 9

8 years ago
http://hg.mozilla.org/mozilla-central/rev/1f3358bd4ef4
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.