Is that in a debug build only? The patch for bug 573841 added a bogus |return JS_FALSE| in the nsXPTType::T_CHAR case in JSData2Native that only gets triggered in debug builds... but will reliably fail conversion of strings to chars in debug builds.
Assignee: general → nobody
blocking2.0: --- → ?
QA Contact: general → xpconnect
Guh!! I am shocked, shocked that we have no test in m-c that tickled this. I'm out of town atm but I'll try to patch later today. If anyone wants to preempt, though...
Created attachment 460932 [details] [diff] [review] patch bz, want to stamp this? mrbkap's at BH this week. I'm going to write a test for this, but I'm at BH too, so I'll follow up when I get back.
Assignee: nobody → dwitte
Status: NEW → ASSIGNED
Attachment #460932 - Flags: review?(bzbarsky)
Comment on attachment 460932 [details] [diff] [review] patch r=me
Attachment #460932 - Flags: review?(bzbarsky) → review+
Comment on attachment 460932 [details] [diff] [review] patch Definitely want this in tm ASAP.
Attachment #460932 - Flags: approval2.0?
It's already a blocker; just land it.
blocking2.0: betaN+ → ?
FWIW I've just applied this to the same tracemonkey build as I had earlier and it works fine. Thanks everyone.
blocking2.0: ? → betaN+
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.