582605 - Lightning stops parsing CalDav Data when it hits the control character with ASCII octal value of '002'

Status: RESOLVED INCOMPLETE

(Calendar :: Provider: CalDAV, defect)

Description

[Patrick Mulrooney]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US) AppleWebKit/533.4 (KHTML, like Gecko) Chrome/5.0.375.99 Safari/533.4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.9pre) Gecko/20100727 Lightning/1.0b2pre Lanikai/3.1.2pre

This does not seem to be an issue in Sunbird, or older versions of Lightning (though we might not just have noticed it), but while Lightning 1b2 is reading in CalDav data if it hits the 'Start of text' Control Character ( ASCII octal '002', hex '02' ) it will stop parsing the data.

If you turn on debugging you see Lightning parsing the data, but it stop immediately after hitting the control character. You do not see the rest of the event ( eg; END:VEVENT, END:VCALENDAR, etc). For me the character was in the 'DESCRIPTION' field, but could occur in SUMMARY and LOCATION as well.

The initial error you come across is Lightning complaining of a lack of 'sync-tokens' as the sync-token is provided after the calendar data, which it never gets to.

If you attempt to import a calendar (ics file) containing the control character to a local calendar it imports without issue, properly handling the character.

Reproducible: Always

Steps to Reproduce:
I am using DAViCal 0.9.9 as my CalDav server.

1. Add the ASCII Character with Octal value '002' to a field
2. Import ICS file with problem character to server (using Lightning to do the import will probably fail)
3. Attempt to refresh remote calendars

Actual Results:  
You get the following error messages..

Warning: CalDAV: Fatal Error doing webdav sync for [Calendar Name]

And...

Error: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsISAXXMLReader.onDataAvailable]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: file:///home/xxxxxx/.thunderbird/xxxxxxx.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/modules/calUtils.jsm -> file:///home/xxxxx/.thunderbird/xxxxxx.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calDavRequestHandlers.js :: wSL_onDataAvailable :: line 482"  data: no]
Source File: file:///home/xxxxx/.thunderbird/xxxxxx.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/modules/calUtils.jsm -> file:///home/xxxxxx/.thunderbird/xxxxx.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calDavRequestHandlers.js
Line: 482


This can easily be fixed by removing the control characters, but the failure is pretty silent. We only noticed it because a lack of events on the calendar.

In all other aspects of Lightning it seems to handle the character correctly, just not when doing CalDav (remote ICS files are fine).

Provided URL has an ICS file that will trigger the problem.

Comment 1

[Patrick Mulrooney]

Attachment: Sample problem ics file

Comment 2

[Pete Smith]

This is happening for me trying to migrate to a DAViCAL server using Windows clients.

Comment 3

[Felix Möller]

I think this is in the same category as bug #489850 ...

Comment 4

[Philipp Kewisch [:Fallen][☁️📆]]

How did you get the character into there? I was trying to reproduce this, but the servers I tried didn't allow me to enter it.