Bug 582643 (0x)

Reject `0x`without any hex digits

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: jorendorff, Assigned: Waldo)

Tracking

Other Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
javascript:alert(0x)

IE rightly rejects this. We should too.
(Assignee)

Comment 1

8 years ago
Created attachment 461419 [details] [diff] [review]
Patch and test

Simple enough, figured I should do this while I was looking at the code.

The exact location for the no-hexdigits check could be a few different places, but this earliest place to check seemed slightly better than other options.
Assignee: general → jwalden+bmo
Status: NEW → ASSIGNED
Attachment #461419 - Flags: review?(jorendorff)
(Reporter)

Comment 2

8 years ago
Comment on attachment 461419 [details] [diff] [review]
Patch and test

Perfect.
Attachment #461419 - Flags: review?(jorendorff) → review+
(Assignee)

Comment 3

8 years ago
http://hg.mozilla.org/tracemonkey/rev/7d02da2df01e
Whiteboard: fixed-in-tracemonkey
(Reporter)

Comment 4

8 years ago
http://hg.mozilla.org/mozilla-central/rev/7d02da2df01e
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.