Closed Bug 582664 Opened 9 years ago Closed 9 years ago

Developer Tools are not accessible from the app button in Windows

Categories

(Firefox :: Menus, defect)

All
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 4.0b3
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: pcwalton, Assigned: pcwalton)

References

Details

Attachments

(3 files)

The only way to access the developer tools in Windows is to either (a) turn on the menu by right-clicking or (b) use the keyboard shortcuts. This hurts discoverability, which is particularly important for the beta audience. For this reason I'm proposing that this block betaN.

I'd like to propose adding a "Developer >" submenu to the "Firefox" button on Windows. Chrome has a "Tools" menu that contains, among other things, View Source, the JavaScript Console, and the Developer Tools. We could add the Web Console, the Inspector, and the View Source option to our "Developer" submenu.
seconded. I think we talked about this during one of our meetings this week and I think it'd be a solid addition to the button menu and aid in discoverability on windows.
Keywords: uiwanted
Attached patch Proposed patch.Splinter Review
Patch to implement this attached. It adds a "Developer >" submenu (which contains View Source, Inspect, and Web Console) below the "History >" menu and above the Customize menu. Tested on try server.
Attachment #461256 - Flags: ui-review?(limi)
Attachment #461256 - Flags: feedback?(rcampbell)
Comment on attachment 461256 [details] [diff] [review]
Proposed patch.

looks good.
Attachment #461256 - Flags: feedback?(rcampbell) → feedback+
Attachment #461256 - Flags: review?(dolske)
Screenshot attached.
Comment on attachment 461256 [details] [diff] [review]
Proposed patch.

Yup, having this in a Developer menu was indeed the plan. There are some tweaks we have to do to the menu in general soon, but I think this can land in the meantime.
Attachment #461256 - Flags: ui-review?(limi) → ui-review+
Comment on attachment 461256 [details] [diff] [review]
Proposed patch.

>+        <menu id="appmenu_developer"
>+              label="&developerMenu.label;">
>+          <menupopup>

Add |id="appmenu_developer_popup"| here. Mostly just so extensions can easily get ahold of it.


>+            <menuitem id="appmenu_pageSource"
>+                      label="&pageSourceCmd.label;"
>+                      command="View:PageSource"/>

Hmm, I was going to r- because the 3 menuitems added here do not have accesskey set, but I see that none of the appmenu entries have accesskeys.

Dao, why's that? Because it's assumed that the appmenu will be mouse-driven, and that keyboard users will be using the traditional menu structure?


>+<!ENTITY developerMenu.label "Developer">

Hmm, I almost wonder if this should this be "Develop" to fit into the traditional verb-oriented menu labels, but that sounds really awkward.
Attachment #461256 - Flags: review?(dolske) → review+
> Dao, why's that? Because it's assumed that the appmenu will be mouse-driven,
> and that keyboard users will be using the traditional menu structure?

Yes.

Why is there a separator between Page Source and Inspect?
Component: Developer Tools → Menus
QA Contact: developer.tools → menus
(In reply to comment #7)
> > Dao, why's that? Because it's assumed that the appmenu will be mouse-driven,
> > and that keyboard users will be using the traditional menu structure?
> 
> Yes.
> 
> Why is there a separator between Page Source and Inspect?

I added that because Page Source is under "View" in the standard menus, while "Inspect" and "Web Console" are under "Tools".
Attachment #461256 - Flags: approval2.0?
Comment on attachment 461256 [details] [diff] [review]
Proposed patch.

a=me
Attachment #461256 - Flags: approval2.0? → approval2.0+
Modified per dolske's comments.
Keywords: uiwantedcheckin-needed
http://hg.mozilla.org/mozilla-central/rev/65e62e55194e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b3
The menu item should say "Developer Tools". No need to file a bug for it, so I'm commenting here.
Er, I managed to check in the wrong version of the patch.

The tree's closed right now, though.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to comment #14)
> Landed the differences:
> http://hg.mozilla.org/mozilla-central/rev/6d7dc709017d

Should this be re-resolved as fixed then?
Status: REOPENED → RESOLVED
blocking2.0: ? → betaN+
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Another thing - the access keys aren't displayed.(ctrl+shift+k, ctrl+shift+i)
Ctrl+Shift+U would fit for Page Source.
You need to log in before you can comment on or make changes to this bug.