Closed Bug 582706 Opened 9 years ago Closed 9 years ago

[regression] Escape key broken by bug 581561

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Details

Attachments

(1 file, 1 obsolete file)

http://hg.mozilla.org/mobile-browser/rev/974c86b77f5f broke BrowserUI.handleEscape, because the new .modal-block element in browser.xul causes it to bail out here every time:

http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser-ui.js#673
Attached patch patch (obsolete) — Splinter Review
Use a different class name for the context-menu block, so it's not detected as a modal dialog.

Also some minor CSS cleanup - more coming in bug 582676.
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Attachment #460974 - Flags: review?(mark.finkle)
Attached patch patch v2Splinter Review
missed one
Attachment #460974 - Attachment is obsolete: true
Attachment #460976 - Flags: review?(mark.finkle)
Attachment #460974 - Flags: review?(mark.finkle)
Attachment #460976 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/c3b93bf20195
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Flags: in-testsuite?
Filed bug 594047 for automated testing of the escape key.
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.