Closed
Bug 582706
Opened 11 years ago
Closed 11 years ago
[regression] Escape key broken by bug 581561
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mbrubeck, Assigned: mbrubeck)
Details
Attachments
(1 file, 1 obsolete file)
3.43 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/mobile-browser/rev/974c86b77f5f broke BrowserUI.handleEscape, because the new .modal-block element in browser.xul causes it to bail out here every time: http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser-ui.js#673
Assignee | ||
Comment 1•11 years ago
|
||
Use a different class name for the context-menu block, so it's not detected as a modal dialog. Also some minor CSS cleanup - more coming in bug 582676.
Assignee | ||
Comment 2•11 years ago
|
||
missed one
Attachment #460974 -
Attachment is obsolete: true
Attachment #460976 -
Flags: review?(mark.finkle)
Attachment #460974 -
Flags: review?(mark.finkle)
Updated•11 years ago
|
Attachment #460976 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 3•11 years ago
|
||
http://hg.mozilla.org/mobile-browser/rev/c3b93bf20195
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•11 years ago
|
Flags: in-testsuite?
Assignee | ||
Comment 4•11 years ago
|
||
Filed bug 594047 for automated testing of the escape key.
Flags: in-testsuite?
You need to log in
before you can comment on or make changes to this bug.
Description
•