582715 - Five message views, not four, and more can be created

Status: RESOLVED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[RickieES aka Ricardo Palomares]

At:

http://hg.mozilla.org/comm-central/file/1dea83e6409f/suite/locales/en-US/chrome/common/help/mail_help.xhtml#l2402

  <li><strong>Custom views</strong>: Choose a custom view. By default you have
    four preset views: <q>People I Know</q>, <q>Recent Mail</q>, <q>Last 5
    Days</q>, and <q>Not Junk</q>.</li>
  <li><strong>Customize</strong>: Choose this option to view or modify
    settings for custom views.</li>


Actually, there are five preset views, not four: People I Know, Recent Mail, Last 5 Days, Not Junk AND Has Attachments. This last one is missing in the above help description.

Besides, Customize allows not only view or modify settings for custom views, but also create new custom views.

Since we are in the middle of mail_help.xhtml split through bug 246405, a patch for this should ideally wait until mail_help.xhtml is fully splitted. Therefore, I'm setting Depends on 246405.

Comment 1

[Edmund Wong (:ewong)]

Attachment: Added the fifth missing view to the list of custom views and added a short notice about creating custom view. (v1)

Comment 2

[RickieES aka Ricardo Palomares]

I'm not a reviewer myself, but I'd say the patch is OK. Thanks for taking care of this, when I filed the bug it was my intention to do it myself, but I half forgot it, half lacked the time to do it.

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 539738 [details] [diff] [review]
Added the fifth missing view to the list of custom views and added a short notice about creating custom view. (v1)

Please fix this while you're here:
1. The label in the UI actually reads "Custom Views", with a capital V.
2. The "Tip" sentence is bad English without an article such as "the" before "message view".
r=me with that.

Note: There's a new menu item, Save View as a Folder, which appears before Customize. We should document that, too, but AFAICS we have no documentation for the underlying feature (saved search folders) yet, so I filed bug 664767 for that.

Comment 4

[Edmund Wong (:ewong)]

Attachment: Added the fifth missing view to the list of custom views and added a short notice about creating custom view. (v2) [Checkin: comments 5 and 6]

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 540303 [details] [diff] [review]
Added the fifth missing view to the list of custom views and added a short notice about creating custom view.  (v2) [Checkin: comments 5 and 6]

http://hg.mozilla.org/comm-central/rev/8a841fad9705

You may wish to have this landed on Aurora, too. For Beta it might be too late.

Comment 6

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 540303 [details] [diff] [review]
Added the fifth missing view to the list of custom views and added a short notice about creating custom view.  (v2) [Checkin: comments 5 and 6]

http://hg.mozilla.org/releases/comm-aurora/rev/6577b0df4dc3

Comment 7

[RickieES aka Ricardo Palomares]

I know I did an informal review and said everything was right, but now that I'm replicating the changes to es-ES, I've noticed that, actually, the English version still says "four views" instead "five views". :-(

Comment 8

[RickieES aka Ricardo Palomares]

(In reply to comment #7)
> I know I did an informal review and said everything was right, but now that
> I'm replicating the changes to es-ES, I've noticed that, actually, the
> English version still says "four views" instead "five views". :-(


Oh, actually the first version of the patch was right wrt to the number of views.

Comment 9

[RickieES aka Ricardo Palomares]

Attachment: Forgotten number change in checked-in patch

Comment 10

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 542991 [details] [diff] [review]
Forgotten number change in checked-in patch

There's a lot more in this patch than this bug, pal. ;-)

And sorry for not catching the regression in between patches. I wasn't expecting that, to be honest.

ewong: As a habit, it's always best to retrieve the last version of a patch from Bugzilla and start with that, in case you don't have it locally anymore. qimportbz helps a lot there.

Comment 11

[RickieES aka Ricardo Palomares]

Attachment: Forgotten number change in checked-in patch, v2 [Checkin: comments 13 and 14]

This time I think I have switched on my brain. :-)

Comment 12

[RickieES aka Ricardo Palomares]

I can't check-in myself. :-)

Comment 13

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 543206 [details] [diff] [review]
Forgotten number change in checked-in patch, v2 [Checkin: comments 13 and 14]

http://hg.mozilla.org/comm-central/rev/90bd3cecdf07

Comment 14

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 543206 [details] [diff] [review]
Forgotten number change in checked-in patch, v2 [Checkin: comments 13 and 14]

http://hg.mozilla.org/releases/comm-aurora/rev/59df0ed227cc