58272 - CTRL-M works but File-->New Message pulldown doesn't

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[ekrock's old account (dead)]

Mozilla/5.0 (Windows; U; WinNT4.0; en-US; m18) Gecko/20001025 Netscape6/6.0

10/25 Commercial on WinNT 4.0 SP4.

To repro:
1) CTRL-M to launch a mail message compose window
2) CTRL-M again; works as expected and second window opens; close it
3) File-->New Message

Expected: new compose window opens
Actual:   nothing happens

Comment 1

[Blake Ross]

what the heck happened to cmd_new?  It apparently no longer exists anywhere.

Comment 2

[Blake Ross]

cmd_newMessage, that is.  reassigning to me to attach the minimum branch fix, 
assuming this gets rtm++ (which it should).  but we should really figure out 
what the heck happened to cmd_newMessage, assuming it existed at one point.

Comment 3

[Blake Ross]

Attachment: patch - please review

Comment 4

[Blake Ross]

Attached a patch.  We can't observe cmd_newMessage because the label for that 
is just "Message" (since it's File > New > Message), so the patch just opens 
the window the same way that the cmd_newMessage broadcaster does.  I still 
don't know why we don't have a command called cmd_newMessage, which is why it 
currently doesn't work:

<broadcaster id="cmd_new" oncommand="goDoCommand('cmd_newMessage')"/>

Anyways, putterman, can you review?  Nominating for rtm.  A menu item that 
doesn't work is embarrassing, and this is an especially important one.

Comment 5

[scottputterman]

this is actually a dup of another bug that we already rtm-'d.  But since you
have a patch to make it work I won't dup it, you have an r=scottip to check it
onto the trunk.

If you find the other bug, you'll see all of the reasoning for not thinking it
has to be fixed for the Netscape release.

Comment 6

[Blake Ross]

*** Bug 55883 has been marked as a duplicate of this bug. ***

Comment 7

[Blake Ross]

k, found it.

who should sr=?

Comment 8

[scottputterman]

alecf or mscott. Since this isn't going to be making the branch, you might want 
to figure out the real cause before checking this in.

Comment 9

[Blake Ross]

there's no cmd_new.  not sure if there ever was, but the new patch works fine 
and does what we do in other places.  cc alecf for sr

Comment 10

[Alec Flett]

sr=alecf

Comment 11

[Blake Ross]

Fix checked in.

Comment 12

[[e-mail] (gone - use [e-mail] instead)]

Verified on Windows NT, 2000112104.  Needing verification on Linux and Mac,
which I can't provide until my machines arrive.  Esther?  Adding verifyme keyword.

Comment 13

[[e-mail] (gone - use [e-mail] instead)]

VERIFIED FIXED.  Mac 2000120708, Linux 2000120721 and NT 4.0 2000120720