JS_NewDoubleValue API is missing post-fatvals

NEW
Unassigned

Status

()

Core
JavaScript Engine
8 years ago
4 years ago

People

(Reporter: Wesley W. Garland, Unassigned)

Tracking

1.9.2 Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

8 years ago
JS_NewDoubleValue() went missing when fatvals landed in TraceMonkey.

As this is still implementable, what do you think about leaving it in to allow embedders to keep using it?  (especially if they support older tracemonkies)
(Reporter)

Comment 1

8 years ago
Created attachment 461224 [details] [diff] [review]
Patch to replace with an inline deprecated function

How about something like this?

It complains if you compile it with GCC, but it still works.
(Reporter)

Comment 2

8 years ago
Created attachment 461228 [details] [diff] [review]
Patch to replace with an inline deprecated function

Whoops, that last patch got eaten by a grue.
Attachment #461224 - Attachment is obsolete: true
(Reporter)

Comment 3

8 years ago
Created attachment 461251 [details] [diff] [review]
Patch to replace with an inline deprecated function
Attachment #461228 - Attachment is obsolete: true
Is this still wanted?
Hmmm, at this point it sounds like it might be easier to just let embedders create that function if they want. But what do you think, Wes?
(Assignee)

Updated

4 years ago
Assignee: general → nobody
You need to log in before you can comment on or make changes to this bug.