582746 - JS_NewDoubleValue API is missing post-fatvals

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Wesley W. Garland]

JS_NewDoubleValue() went missing when fatvals landed in TraceMonkey.

As this is still implementable, what do you think about leaving it in to allow embedders to keep using it?  (especially if they support older tracemonkies)

Comment 1

[Wesley W. Garland]

Attachment: Patch to replace with an inline deprecated function

How about something like this?

It complains if you compile it with GCC, but it still works.

Comment 2

[Wesley W. Garland]

Attachment: Patch to replace with an inline deprecated function

Whoops, that last patch got eaten by a grue.

Comment 3

[Wesley W. Garland]

Attachment: Patch to replace with an inline deprecated function

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Is this still wanted?

Comment 5

[David Mandelin [:dmandelin]]

Hmmm, at this point it sounds like it might be easier to just let embedders create that function if they want. But what do you think, Wes?

Comment 6

[Matthew Gaudet (he/him) [:mgaudet]]

I figure 13 years on this may not be necessary