If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

list properties in leaked objects with generic toString methods

RESOLVED FIXED

Status

Add-on SDK
General
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: myk, Assigned: myk)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

7 years ago
Created attachment 461018 [details] [diff] [review]
patch v1: implements change

Leak warnings about objects with generic toString methods should list the properties in the object to make it easier to identify the objects via duck typing.
Attachment #461018 - Flags: review?(avarma)

Comment 1

7 years ago
Comment on attachment 461018 [details] [diff] [review]
patch v1: implements change

Yeah, awesome!
Attachment #461018 - Flags: review?(avarma) → review+

Comment 2

7 years ago
Created attachment 461022 [details] [diff] [review]
print bins along with leaked objects

Not to hijack this bug, but I've used this patch to print "bin" info along with leaked objects, in case you're interested...
(Assignee)

Comment 3

7 years ago
Created attachment 461028 [details] [diff] [review]
patch v2: incorporates Drew's patch

I'm interested!  Here's a combined patch.
Assignee: nobody → myk
Attachment #461018 - Attachment is obsolete: true
Attachment #461022 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #461028 - Flags: review?(avarma)

Comment 4

7 years ago
Comment on attachment 461028 [details] [diff] [review]
patch v2: incorporates Drew's patch

Fine tag-teaming.
Attachment #461028 - Flags: review?(avarma) → review+
(Assignee)

Comment 5

7 years ago
https://hg.mozilla.org/labs/jetpack-sdk/rev/9e28b016db36
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

7 years ago
The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".
Component: Jetpack SDK → General
Product: Mozilla Labs → Add-on SDK
QA Contact: jetpack-sdk → general
You need to log in before you can comment on or make changes to this bug.