Closed
Bug 58281
Opened 25 years ago
Closed 25 years ago
Memory leaks in nsHTMLEditor.cpp
Categories
(Core :: DOM: Editor, defect, P3)
Tracking
()
VERIFIED
FIXED
mozilla0.9.1
People
(Reporter: sfraser_bugs, Assigned: mozeditor)
Details
(Keywords: memory-leak)
Attachments
(1 file)
|
4.41 KB,
patch
|
Details | Diff | Splinter Review |
The following lines have bad refcounting behaviour:
2634: nsCOMPtr<nsISupports> isupports = nodeList->ElementAt(0);
2690: nsCOMPtr<nsISupports> isup = nodeList->ElementAt(0);
2719: nsCOMPtr<nsISupports> isupports = nodeList->ElementAt(j);
2766: nsCOMPtr<nsISupports> isupports = listAndTableArray->
ElementAt(highWaterMark);
2772: isup = nodeList->ElementAt(0);
etc etc.
nsHTMLEditor doesn't even compile in an optimized build, seeminly because
InsertHTMLWithCharsetAndContext() is so large. This needs fixing also.
Keywords: mlk
| Assignee | ||
Comment 3•25 years ago
|
||
moving a bunch of 0.9 bugs to 0.9.1
Target Milestone: mozilla0.9 → mozilla0.9.1
Comment 4•25 years ago
|
||
nominating for dogfood (from sdagley's list of bugs that are good candidates for
our next release)
Keywords: nsdogfood
| Assignee | ||
Comment 5•25 years ago
|
||
attaching patch, need sr
| Assignee | ||
Comment 6•25 years ago
|
||
Thanks for fixing these Joe! sr=kin@netscape.com
| Reporter | ||
Comment 8•25 years ago
|
||
r=sfraser
| Assignee | ||
Comment 9•25 years ago
|
||
checked in last night.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Comment 10•25 years ago
|
||
simon/joe, please verify this one...thanks
You need to log in
before you can comment on or make changes to this bug.
Description
•