RSS feed for individual review threads is the entire RSS-review feed

VERIFIED FIXED in 4.x (triaged)

Status

addons.mozilla.org Graveyard
Public Pages
P5
trivial
VERIFIED FIXED
8 years ago
3 years ago

People

(Reporter: stephend, Assigned: jdev005)

Tracking

unspecified
4.x (triaged)

Details

(Whiteboard: [mentor=clouserw][lang=py], URL)

Attachments

(2 attachments)

(Reporter)

Description

8 years ago
The RSS feed for https://preview.addons.mozilla.org/z/en-US/firefox/addon/1865/reviews/229534/, which is a thread containing only 2 posts, is the full add-on-RSS feed: https://preview.addons.mozilla.org/z/en-US/firefox/addon/1865/reviews/format:rss; not sure if we want a separate feed to show/follow specific review threads?
(Reporter)

Updated

8 years ago
No longer blocks: 557879
(Reporter)

Updated

8 years ago
Blocks: 557879
We don't.  We should just remove the RSS from these pages.
Severity: normal → trivial
Target Milestone: --- → 4.x (triaged)
Assignee: nobody → chenba
Stephen, is this still an issue? 

This link below returns a 404.

https://addons.allizom.org/z/en-US/firefox/addon/adblock-plus/reviews/305477/format:rss
(Reporter)

Comment 3

7 years ago
(In reply to Arron Schaar [:arron] from comment #2)
> Stephen, is this still an issue? 
> 
> This link below returns a 404.
> 
> https://addons.allizom.org/z/en-US/firefox/addon/adblock-plus/reviews/305477/
> format:rss

Arron, I don't actually know, but looking on https://addons-dev.allizom.org/en-US/firefox/addon/adblock-plus/reviews/318163/, and checking its published feed via Tools | Page Info, the link is just to https://addons-dev.allizom.org/en-US/firefox/addon/adblock-plus/reviews/format:rss, not the individual thread.

Not sure if the above is a bug or intended.
(Reporter)

Comment 4

7 years ago
(Or did I just confirm that the bug still exists?)  Regardless, here's a screenshot.
(Reporter)

Comment 5

7 years ago
Created attachment 586259 [details]
Screenshot of current behavior
Assignee: chenba → nobody
Priority: -- → P5
Whiteboard: [mentor=clouserw][lang=py]
(Assignee)

Comment 6

6 years ago
can i be assigned this bug ?
Sure.  Do you need help getting started?
Assignee: nobody → jdev005
(Assignee)

Comment 8

6 years ago
yes i do ,i haven't fixed and bug or submitted a patch before , so i really help to get started
(Assignee)

Comment 9

6 years ago
the changes made from the original 


diff --git a/apps/reviews/templates/reviews/review_list.html b/apps/reviews/temp
index c1190c8..f17ee04 100644
--- a/apps/reviews/templates/reviews/review_list.html
+++ b/apps/reviews/templates/reviews/review_list.html
@@ -6,12 +6,10 @@
 
 {% block bodyclass %}reviews gutter{% endblock %}
 
-{% if page == 'list' %}
-  {% block rss_feed %}
-  <link  rel="alternate" type="application/rss+xml"
-         title="RSS" href="{{ addon.reviews_url }}format:rss">
-  {% endblock %}
-{% endif %}
+{% block rss_feed %}
+<link  rel="alternate" type="application/rss+xml"
+       title="RSS" href="{{ addon.reviews_url }}format:rss">
+{% endblock %}
 
 {% block content %}
   {{ impala_breadcrumbs([(addon.type_url(), amo.ADDON_TYPES[addon.type]),
(END)
(Assignee)

Comment 10

6 years ago
Created attachment 641779 [details] [diff] [review]
the new file with the required changes
Attachment #641779 - Flags: review?(clouserw)

Comment 11

6 years ago
Fixed:

https://github.com/mozilla/zamboni/commit/4a3b04e7b9e0b6995d0ed258f64f24466045491d
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Thanks for the patch.  Matt flipped your if() inside of the {% block %} because otherwise it was defaulting to show it.  And thanks Matt for the commit.  This will go live next Thursday at 2pm
(Reporter)

Comment 13

6 years ago
Verified FIXED; shows up on https://addons-dev.allizom.org/en-US/firefox/addon/firebug/reviews, which has https://addons-dev.allizom.org/en-US/firefox/addon/firebug/reviews/format:rss, but individual review threads don't.
Status: RESOLVED → VERIFIED
Attachment #641779 - Flags: review?(clouserw)
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.