582912 - Extend copy paste support of Fennec's Qt port

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Antti Järvelin]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.8) Gecko/20100723 Ubuntu/10.04 (lucid) Firefox/3.6.8
Build Identifier: Mozilla/5.0 (X11; Linux armv7I; rv:2.0b3pre) Gecko/20100727 Firefox/4.0b3pre Fennec/2.0a1pre

Extend copy/paste support of Fennec's Qt-port

This includes:
1. Pasting text into html text fields 
2. Paste clipboard contents into editable html elements
3. Copy functionality for text & html contents of web pages
4. Cut functionality for text fields and content editable html elements
5. The user should be able to trigger the above actions using context sensitive menu or keyboard
shortcuts if keyboard is available
6. Users should be able to copy link locations into clipboard with context
sensitive menus.
7. Users should be able to copy image locations into clipboard with context
sensitive menus.


Reproducible: Always

Comment 1

[Antti Järvelin]

Attachment: Fix proposal for fennec

This is the fennec part of the copy-paste support

Comment 2

[Antti Järvelin]

Attachment: Fix proposal for xulrunner

This is the xulrunner part of the copy-paste support.  It extends the copy paste support of the xulrunner's Qt port.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 461174 [details] [diff] [review]
Fix proposal for xulrunner

pushing the Qt part to Doug

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 461173 [details] [diff] [review]
Fix proposal for fennec

* Could you make the using: hg diff -p -U 8  (or similar)
* You have some extra files in the patch
* The ContextHandler was just updated to use a new method to register actions

Please update the patch.

We also need to check with the UX lead to see if all the new context menu items are wanted.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Madhava - What do you think of adding the following to the context menu:
"Copy Link"
"Copy Image Location"
"Copy"  (for text)
"Cut"
"Paste"

Comment 6

[Antti Järvelin]

Thanks for your comments, I'll update (both of) the patches.

(In reply to comment #4)
> Comment on attachment 461173 [details] [diff] [review]
> Fix proposal for fennec
> 
> * Could you make the using: hg diff -p -U 8  (or similar)
> * You have some extra files in the patch
> * The ContextHandler was just updated to use a new method to register actions
> 
> Please update the patch.
> 
> We also need to check with the UX lead to see if all the new context menu items
> are wanted.

Comment 7

[Antti Järvelin]

Attachment: Corrected patch for xulrunner

This patch extends the copy/paste support of xulrunner's Qt port.

Now the patch format should be ok.

Comment 8

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/0e00a31fb25c

Comment 9

[Antti Järvelin]

Attachment: Fix proposal for fennec

Now the patch should be correctly formated.  Also updated the ContextHandler related code.

Comment 10

[Tuukka Tolvanen (sp3000)]

Comment on attachment 462000 [details] [diff] [review]
Fix proposal for fennec

>+            <label value="&contextCopyImage.label"/>

XML Parsing Error: not well-formed (missing semicolon)

Comment 11

[Oleg Romashin (:romaxa)]

Comment on attachment 461481 [details] [diff] [review]
Corrected patch for xulrunner

I guess this is somehow landed already

Comment 12

[Jan Arne Petersen]

Just the xulrunner part of the patch landed.

Fennec part still needs to be reviewed.

Comment 14

[Jan Arne Petersen]

Resolve fixed. For fennec part there is now bug 585875.

Comment 15

[Mark Finkle (:mfinkle) (use needinfo?)]

Agreed