582949 - Composition's "Save Message" confirmation dialogue should revert to using simple "Yes, No, Cancel" buttons (vs. "Save, Don't Save, Cancel")

Status: RESOLVED WONTFIX

(Thunderbird :: Message Compose Window, defect)

Description

[Phil Lacy]

Not only is 's' and 'd' physically close on the keyboard, but this type of dialog box is normally implemented as a simple "save document?" Yes or No query.

Comment 1

[Wayne Mery (:wsmwk)]

Attachment: Yes, No, Cancel vs Save, Don't Save, Cancel

Bryan, no code here, just mock up. do you agree this is the way to go?

Steps
1. compose message, don't send
2. File, Close

(there are of course similar dialogs in other realms)

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 507233 [details]
Yes, No, Cancel vs   Save, Don't Save, Cancel

We could try to improve the wording of Save, Don't Save to Save, Abandon.

These types of dialogs are new but are an improvement over the old.  The buttons use "actionable" terms.  With Yes/No buttons the person has to read the text involved to understand the correct action would be.  This is bad for a number of reasons mostly because people don't read the text.  Actionable text on buttons allows people to only read what they are clicking to understand the action that will be taken.

That said, if there is a suggestion to improve the keyboard shortcut used such that they aren't close to each other we could look into improving that.

Comment 3

[Thomas D. (:thomas8)]

This is a well-founded wontfix per Bryan's comment 2 with ui-review-.

(In reply to Bryan Clark [:clarkbw] from comment #2)
> That said, if there is a suggestion to improve the keyboard shortcut used
> such that they aren't close to each other we could look into improving that.

I filed that as followup bug 759053.

Comment 4

[Thomas D. (:thomas8)]

Clarifying summary to match the part of comment 0 which was correctly wontfixed here.

Comment 5

[Thomas D. (:thomas8)]

FTR:

(In reply to Phil Lacy from comment #0)
> Not only is 's' and 'd' physically close on the keyboard

...which is very error-prone with potential for accidental dataloss indeed. Furthermore, Windows default access key for "Don't Save" or "No" buttons is "N". That has been fixed for toolkit in my bug 759053, but surprisingly not yet bubbled into TB release as of now. I've inquired into that.