Closed Bug 582955 Opened 14 years ago Closed 14 years ago

Require yasm for arches where we need it

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking2.0 betaN+)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: benjamin, Assigned: benjamin)

Details

Attachments

(1 file)

Require YASM, rev. 1
3.05 KB, patch
ted
: review+
Details | Diff | Splinter Review 
Builds should be deterministic, not based on whatever tools are installed on the build machine. We should require yasm for arches where we have assembly for it.

I happened to discover this accidentally via http://www.listshow.net/201007/ubuntu-mozillateam/30042-xulrunner-should-depend-on-yasm.html

        Attachment #461210 -
        Flags: review?(ted.mielczarek)

    
    

    
  
I agree, we should make this change.

    
    

    
  
Comment on attachment 461210 [details] [diff] [review]
Require YASM, rev. 1

Looks like it's just the "yasm" package here on Ubuntu, so that's easy enough. Please fix the error message to have more details (including the exact --disable-webm switch) like the one about MASM above.

        Attachment #461210 -
        Flags: review?(ted.mielczarek) → review+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/f9bfe618ccec
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED

    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: