583001 - narcissus REPL

Status: RESOLVED FIXED

(Other Applications Graveyard :: Narcissus, defect)

Description

[Dave Herman [:dherman]]

It should be pretty easy to add an interactive mode to Narcissus, so it's more-or-less drop-in-replaceable for the JS shell.

Dave

Comment 1

[Dave Herman [:dherman]]

Attachment: adds interactive REPL to narcissus

Comment 2

[Patrick Walton (:pcwalton)]

Comment on attachment 462205 [details] [diff] [review]
adds interactive REPL to narcissus

>+        if (typeof x == "object") {
>+            if (x != null && "toSource" in x) {
>+                try {
>+                    print(x.toSource());
>+                } catch (e) {
>+                }

Maybe something should be printed here.

>+            } else {
>+                print("null");
>+            }
>+        } else if (typeof x == "string") {
>+            print(uneval(x));
>+        } else if (typeof x != "undefined") {
>+            print(String(x));

Do you mean the string() function below?

Comment 3

[Dave Herman [:dherman]]

> Maybe something should be printed here.

I should've commented-- the somewhat weird logic is (at least roughly) tracking the JS shell, just because I figured acting gratuitously differently might confuse someone trying to debug Narcissus. I'll add comments to the function.

> >+        } else if (typeof x != "undefined") {
> >+            print(String(x));
> 
> Do you mean the string() function below?

Since it's not an object, it can't throw, so there's no need to call the string() function. I'll add a comment.

Dave

Comment 4

[Dave Herman [:dherman]]

Attachment: adds interactive REPL to narcissus

Rebased and added comments to address pwalton's review.

Dave

Comment 5

[Patrick Walton (:pcwalton)]

Comment on attachment 463346 [details] [diff] [review]
adds interactive REPL to narcissus

r=me

Comment 6

[Dave Herman [:dherman]]

http://hg.mozilla.org/tracemonkey/rev/f46f2b605fb9