583056 - XPCOM-enabled child processes spew "WARNING: XPCOM objects created/destroyed from static ctor/dtor" on shutdown

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

It's something dumb, patch will be self-explanatory.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Have MessageLoop die before NS_LogTerm() so as to avoid spurious xpcom-dtor-from-static-context warnings

I have another patch to turn these warnings into RUNTIMEABORT() if an env var is set, so I've definitely confirmed the patch fixes the problem ;).

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This patch moves the MessageLoopUI in child process's into its own lexical scope, so that after we exit the loop (when we're ready to shutdown), the MessageLoopUI is destroyed before we call LogTerm().  Previously, LogTerm() happened before ~MessageLoop, and the XPCOM-y things destroyed in ~MessageLoop (in content processes) triggered spurious XPCOM-dtor-from-static-context warnings.  IMHO this patch has zero risk, it just fixes spurious warnings.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

http://hg.mozilla.org/mozilla-central/rev/836c1ab26030