Closed
Bug 583059
Opened 15 years ago
Closed 15 years ago
Make it easier to debug static-XPCOM-ctor/dtor warnings
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
People
(Reporter: cjones, Assigned: cjones)
Details
Attachments
(1 file)
|
2.22 KB,
patch
|
dbaron
:
review+
sdwilsh
:
approval2.0+
|
Details | Diff | Splinter Review |
No description provided.
| Assignee | ||
Comment 1•15 years ago
|
||
Attachment #461318 -
Flags: review?(dbaron)
Comment on attachment 461318 [details] [diff] [review]
Make it possible to break on failed static-XPCOM-ctor/dtor checks and add an env var to make failed checks fatal
probably better to make the #define in the #else define it to "PR_BEGIN_MACRO PR_END_MACRO". r=dbaron with that
Attachment #461318 -
Flags: review?(dbaron) → review+
| Assignee | ||
Comment 3•15 years ago
|
||
Oh, good call. I went ahead and did that for the #if too, so that both create a block scope.
| Assignee | ||
Comment 4•15 years ago
|
||
Comment on attachment 461318 [details] [diff] [review]
Make it possible to break on failed static-XPCOM-ctor/dtor checks and add an env var to make failed checks fatal
Pretty useful IMHO and not risky in the slightest.
Attachment #461318 -
Flags: approval2.0?
Updated•15 years ago
|
Attachment #461318 -
Flags: approval2.0? → approval2.0+
| Assignee | ||
Comment 5•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•