Web Console input and output display should use the same font and size

REOPENED
Unassigned

Status

()

Toolkit
Themes
REOPENED
8 years ago
5 years ago

People

(Reporter: ddahl, Unassigned)

Tracking

Trunk
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kd4b6][approved-patches-landed])

Attachments

(2 attachments)

(Reporter)

Description

8 years ago
This is just a reminder bug to make sure the font and font size is the same for all console output
(Reporter)

Updated

8 years ago
Blocks: 529086
Target Milestone: --- → Firefox 4.0b3
(Reporter)

Comment 1

8 years ago
Just don't want it to fall through the cracks, this is the kind of thing that users will file a dozen bugs for:)

Comment 2

8 years ago
Created attachment 462051 [details]
Objects appear to display with a different font size

Objects appear to be displayed with a different font size than the rest of the output.

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b3pre) Gecko/20100801 Minefield/4.0b3pre

Updated

8 years ago
Whiteboard: [kd4b4]
(Reporter)

Comment 3

8 years ago
Created attachment 469554 [details] [diff] [review]
patch 0

I think this should fix the font output issue. it bothers me greatly. I don't think we can remove this class, as it is used programatically. i think we may need an additional class for "jsterm-output-object"
Attachment #469554 - Flags: feedback?
(Reporter)

Updated

8 years ago
Attachment #469554 - Flags: feedback? → feedback?(jviereck)

Comment 4

8 years ago
Comment on attachment 469554 [details] [diff] [review]
patch 0

Arrrrggg, this was annoying me for so long as well and the fix is that simple... Thanks David :)
Attachment #469554 - Flags: feedback?(jviereck) → feedback+
(Reporter)

Updated

8 years ago
Attachment #469554 - Flags: review?(dietrich)

Updated

8 years ago
Assignee: nobody → ddahl

Updated

8 years ago
Whiteboard: [kd4b4] → [kd4b6]
Attachment #469554 - Flags: review?(dietrich)
Attachment #469554 - Flags: review+
Attachment #469554 - Flags: approval2.0+
(Reporter)

Comment 5

8 years ago
http://hg.mozilla.org/mozilla-central/rev/b6df151f4fe1
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 4.0b3 → Firefox 4.0b6
font-size: 1em; is a no-op here, isn't it?
Please put theme-only bugs in the corresponding toolkit or firefox component.
Component: Developer Tools → Themes
Product: Firefox → Toolkit
QA Contact: developer.tools → themes
Target Milestone: Firefox 4.0b6 → ---
(Reporter)

Comment 7

8 years ago
(In reply to comment #6)
> font-size: 1em; is a no-op here, isn't it?

I kept the selector as it is used in querySelector queries and will be used for additional styling.
You kept the class because it's used in querySelector queries and will be used for additional styling, but surely that's not the reason for keeping font-size: 1em;?
(Reporter)

Comment 9

8 years ago
(In reply to comment #8)
> You kept the class because it's used in querySelector queries and will be used
> for additional styling, but surely that's not the reason for keeping font-size:
> 1em;?

Yeah, and actually, I thought it needed that font-size via DOM Inspector tweaks. Turns out I should have just removed the font-size entirely.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [kd4b6] → [kd4b6][approved-patches-landed]
(Reporter)

Updated

5 years ago
Assignee: ddahl → nobody
You need to log in before you can comment on or make changes to this bug.