Closed Bug 583101 Opened 9 years ago Closed 10 months ago

Web Console input and output display should use the same font and size

Categories

(Toolkit :: Themes, defect)

x86
All
defect
Not set

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: ddahl, Unassigned)

References

Details

(Whiteboard: [kd4b6][approved-patches-landed])

Attachments

(2 files)

This is just a reminder bug to make sure the font and font size is the same for all console output
Blocks: 529086
Target Milestone: --- → Firefox 4.0b3
Just don't want it to fall through the cracks, this is the kind of thing that users will file a dozen bugs for:)
Objects appear to be displayed with a different font size than the rest of the output.

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b3pre) Gecko/20100801 Minefield/4.0b3pre
Whiteboard: [kd4b4]
Attached patch patch 0Splinter Review
I think this should fix the font output issue. it bothers me greatly. I don't think we can remove this class, as it is used programatically. i think we may need an additional class for "jsterm-output-object"
Attachment #469554 - Flags: feedback?
Attachment #469554 - Flags: feedback? → feedback?(jviereck)
Comment on attachment 469554 [details] [diff] [review]
patch 0

Arrrrggg, this was annoying me for so long as well and the fix is that simple... Thanks David :)
Attachment #469554 - Flags: feedback?(jviereck) → feedback+
Attachment #469554 - Flags: review?(dietrich)
Assignee: nobody → ddahl
Whiteboard: [kd4b4] → [kd4b6]
Attachment #469554 - Flags: review?(dietrich)
Attachment #469554 - Flags: review+
Attachment #469554 - Flags: approval2.0+
http://hg.mozilla.org/mozilla-central/rev/b6df151f4fe1
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 4.0b3 → Firefox 4.0b6
font-size: 1em; is a no-op here, isn't it?
Please put theme-only bugs in the corresponding toolkit or firefox component.
Component: Developer Tools → Themes
Product: Firefox → Toolkit
QA Contact: developer.tools → themes
Target Milestone: Firefox 4.0b6 → ---
(In reply to comment #6)
> font-size: 1em; is a no-op here, isn't it?

I kept the selector as it is used in querySelector queries and will be used for additional styling.
You kept the class because it's used in querySelector queries and will be used for additional styling, but surely that's not the reason for keeping font-size: 1em;?
(In reply to comment #8)
> You kept the class because it's used in querySelector queries and will be used
> for additional styling, but surely that's not the reason for keeping font-size:
> 1em;?

Yeah, and actually, I thought it needed that font-size via DOM Inspector tweaks. Turns out I should have just removed the font-size entirely.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [kd4b6] → [kd4b6][approved-patches-landed]
Assignee: ddahl → nobody
We do have the same font now (I don't know when it was fixed though)
Status: REOPENED → RESOLVED
Closed: 9 years ago10 months ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.