Closed Bug 583123 Opened 10 years ago Closed 10 years ago

Don't bfcache closed popups

Categories

(SeaMonkey :: Tabbed Browser, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file)

Some of the dom tests are failing because they try to count how many popups can be opened before they are automatically blocked. Unfortunately bfcached popups are included in the count, although the test isn't expecting them. We can just turn off bfcaching closed popups without affecting manually opened tabs.
Attached patch Possible patchSplinter Review
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #461389 - Flags: review?(iann_bugzilla)
Comment on attachment 461389 [details] [diff] [review]
Possible patch

nit: are we sure we want a pref here? Especially a pref that is not cached?

I'm not sure the benefits of a pref are as useful. and if we do want a pref, I'd argue we should cache it rather than forcing a pref read everytime we want/need to check it.
(In reply to comment #2)
> (From update of attachment 461389 [details] [diff] [review])
> Especially a pref that is not cached?
In case it's not entirely obvious, tabbrowser caches no prefs at all.
Attachment #461389 - Flags: review?(iann_bugzilla) → review+
Pushed changeset 406d62a2044a to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.