Don't bfcache closed popups

RESOLVED FIXED

Status

SeaMonkey
Tabbed Browser
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Some of the dom tests are failing because they try to count how many popups can be opened before they are automatically blocked. Unfortunately bfcached popups are included in the count, although the test isn't expecting them. We can just turn off bfcaching closed popups without affecting manually opened tabs.
(Assignee)

Comment 1

8 years ago
Created attachment 461389 [details] [diff] [review]
Possible patch
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #461389 - Flags: review?(iann_bugzilla)
Comment on attachment 461389 [details] [diff] [review]
Possible patch

nit: are we sure we want a pref here? Especially a pref that is not cached?

I'm not sure the benefits of a pref are as useful. and if we do want a pref, I'd argue we should cache it rather than forcing a pref read everytime we want/need to check it.
(Assignee)

Comment 3

8 years ago
(In reply to comment #2)
> (From update of attachment 461389 [details] [diff] [review])
> Especially a pref that is not cached?
In case it's not entirely obvious, tabbrowser caches no prefs at all.

Updated

8 years ago
Attachment #461389 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 4

8 years ago
Pushed changeset 406d62a2044a to comm-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.