583145 - Theme the Web Console filter bar appropriately on the Mac

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Patrick Walton (:pcwalton)]

Attachment: [backed-out] Proposed patch.

Currently, the filter bar looks like another part of the toolbar on the Mac. It would possibly look better if it were closer in appearance to the Find bar (compare the "Code" bar in the Error Console).

The attached patch implements this.

Comment 1

[David Dahl :ddahl]

Comment on attachment 461423 [details] [diff] [review]
[backed-out] Proposed patch.

I'd love to know what @scopeBarBackground@ replaces to. My mac hg repo is crapped out on me right now. Can you attach a screenshot?

Comment 2

[Patrick Walton (:pcwalton)]

Attachment: Screenshot.

Screenshot attached.

Will need to see how the Console looks with a persona; this will likely be a separate bug.

Comment 3

[David Dahl :ddahl]

lookin' good

Comment 4

[Kevin Dangoor]

This is a small patch and it does improve the appearance, so we should definitely put it up for review.

Comment 5

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 461423 [details] [diff] [review]
[backed-out] Proposed patch.

http://hg.mozilla.org/mozilla-central/rev/371d935c6f1a

Comment 6

[Patrick Walton (:pcwalton)]

Looks like this one conflicted with some other CSS changes.

Comment 7

[Patrick Walton (:pcwalton)]

Attachment: [checked-in] Proposed patch (trunk rebase 2010-08-09).

New patch attached.

Comment 8

[Rob Campbell [:rc] (:robcee)]

backed out:
http://hg.mozilla.org/mozilla-central/rev/36edf82697a1

Comment 9

[Dietrich Ayala (:dietrich)]

Why was the original patch backed out? What changes were made to solve whatever that problem was?

Comment 10

[Rob Campbell [:rc] (:robcee)]

It was backed out due to a conflict with some other patches that landed yesterday.

you can see what was changed by comparing the two patches, though you'll have to ask Patrick for more in-depth description of why those were needed.

Comment 11

[Rob Campbell [:rc] (:robcee)]

I think dietrich's approval from the previous patch is probably sufficient.

Comment 12

[Patrick Walton (:pcwalton)]

The background wasn't taking effect anymore due to CSS selector rule matching, and the border looked wrong. Perhaps some other, global Mac styling changes caused the regression in functionality? I haven't managed to figure out the reason yet, but the CSS changes in the new patch fixed the issue.

Comment 13

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 464182 [details] [diff] [review]
[checked-in] Proposed patch (trunk rebase 2010-08-09).

http://hg.mozilla.org/mozilla-central/rev/ccfdad9f5c93

Comment 14

[Patrick Walton (:pcwalton)]

This needs to be backed out. The HTML+XUL mix in the console means that the @namespace declaration in the CSS is wrong. It's causing all sorts of regressions (no colors and inability to live-filter messages with the patches in bug 583359).

Comment 15

[Patrick Walton (:pcwalton)]

Attachment: Proposed patch, version 2.

New patch attached.

Comment 16

[Patrick Walton (:pcwalton)]

Will add a test case for this tomorrow to prevent this from happening again.

Comment 17

[David Dahl :ddahl]

Comment on attachment 465061 [details] [diff] [review]
Proposed patch, version 2.

gavin@46242
168/* these need to be revised ... */
gavin@46242
169.hud-console-filter-toolbar {
mwu@49618
170 padding: 1px 0px;
ddahl@43820
171 -moz-box-align: center;
ddahl@43820
172} 

According to blame the comment is from gavin. are these "revised" now? can we remove the comment? Either way, f+ (why does 'f+' seem wrong?)

Comment 19

[Patrick Walton (:pcwalton)]

Attachment: Proposed patch, version 2 (revised per feedback).

Patch rebased to trunk and updated per feedback. Review requested.

Comment 20

[David Dahl :ddahl]

pushed http://hg.mozilla.org/mozilla-central/rev/dce14e8e8a5b