Closed Bug 583145 Opened 12 years ago Closed 12 years ago

Theme the Web Console filter bar appropriately on the Mac

Categories

(DevTools :: General, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: pcwalton, Assigned: pcwalton)

References

Details

(Whiteboard: [kd4b5])

Attachments

(3 files, 2 obsolete files)

Attached patch [backed-out] Proposed patch. (obsolete) — Splinter Review
Currently, the filter bar looks like another part of the toolbar on the Mac. It would possibly look better if it were closer in appearance to the Find bar (compare the "Code" bar in the Error Console).

The attached patch implements this.
Attachment #461423 - Flags: feedback?(ddahl)
Summary: Theme the Web Console filter bar appropriately → Theme the Web Console filter bar appropriately on the Mac
Whiteboard: [kd4b4]
Comment on attachment 461423 [details] [diff] [review]
[backed-out] Proposed patch.

I'd love to know what @scopeBarBackground@ replaces to. My mac hg repo is crapped out on me right now. Can you attach a screenshot?
Attachment #461423 - Flags: feedback?(ddahl) → feedback+
Attached image Screenshot.
Screenshot attached.

Will need to see how the Console looks with a persona; this will likely be a separate bug.
lookin' good
This is a small patch and it does improve the appearance, so we should definitely put it up for review.
Assignee: nobody → pwalton
Attachment #461423 - Flags: review?(dietrich)
Attachment #461423 - Flags: review?(dietrich) → review+
Attachment #461423 - Flags: approval2.0?
Attachment #461423 - Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
Comment on attachment 461423 [details] [diff] [review]
[backed-out] Proposed patch.

http://hg.mozilla.org/mozilla-central/rev/371d935c6f1a
Attachment #461423 - Attachment description: Proposed patch. → [checked-in] Proposed patch.
Status: NEW → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Looks like this one conflicted with some other CSS changes.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
New patch attached.
Attachment #461423 - Attachment is obsolete: true
Attachment #464182 - Flags: feedback?(ddahl)
Attachment #464182 - Flags: feedback?(ddahl) → feedback+
Version: unspecified → Trunk
Attachment #464182 - Flags: review?(dietrich)
Whiteboard: [kd4b4] → [kd4b4][needs-backout]
Whiteboard: [kd4b4][needs-backout] → [kd4b4]
Attachment #461423 - Attachment description: [checked-in] Proposed patch. → [backed-out] Proposed patch.
Why was the original patch backed out? What changes were made to solve whatever that problem was?
It was backed out due to a conflict with some other patches that landed yesterday.

you can see what was changed by comparing the two patches, though you'll have to ask Patrick for more in-depth description of why those were needed.
Attachment #464182 - Flags: review?(dietrich) → review+
Attachment #464182 - Flags: approval2.0?
I think dietrich's approval from the previous patch is probably sufficient.
The background wasn't taking effect anymore due to CSS selector rule matching, and the border looked wrong. Perhaps some other, global Mac styling changes caused the regression in functionality? I haven't managed to figure out the reason yet, but the CSS changes in the new patch fixed the issue.
Comment on attachment 464182 [details] [diff] [review]
[checked-in] Proposed patch (trunk rebase 2010-08-09).

http://hg.mozilla.org/mozilla-central/rev/ccfdad9f5c93
Attachment #464182 - Attachment description: Proposed patch (trunk rebase 2010-08-09). → [checked-in] Proposed patch (trunk rebase 2010-08-09).
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
This needs to be backed out. The HTML+XUL mix in the console means that the @namespace declaration in the CSS is wrong. It's causing all sorts of regressions (no colors and inability to live-filter messages with the patches in bug 583359).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
New patch attached.
Attachment #464182 - Attachment is obsolete: true
Attachment #465061 - Flags: feedback?(ddahl)
Attachment #464182 - Flags: approval2.0?
Will add a test case for this tomorrow to prevent this from happening again.
Comment on attachment 465061 [details] [diff] [review]
Proposed patch, version 2.

gavin@46242
168/* these need to be revised ... */
gavin@46242
169.hud-console-filter-toolbar {
mwu@49618
170 padding: 1px 0px;
ddahl@43820
171 -moz-box-align: center;
ddahl@43820
172} 

According to blame the comment is from gavin. are these "revised" now? can we remove the comment? Either way, f+ (why does 'f+' seem wrong?)
Attachment #465061 - Flags: feedback?(ddahl) → feedback+
Whiteboard: [kd4b4] → [kd4b5]
Duplicate of this bug: 571634
Patch rebased to trunk and updated per feedback. Review requested.
Attachment #465848 - Flags: review?(dietrich)
Attachment #465848 - Flags: review?(dietrich)
Attachment #465848 - Flags: review+
Attachment #465848 - Flags: approval2.0+
Keywords: checkin-needed
pushed http://hg.mozilla.org/mozilla-central/rev/dce14e8e8a5b
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.