Closed Bug 583152 Opened 10 years ago Closed 10 years ago

Improved support for the VKB on MeegoTouch

Categories

(Core Graveyard :: Widget: Qt, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: steffen.imhof, Unassigned)

References

Details

Attachments

(1 file, 2 obsolete files)

The attached patch uses the correct enums to switch to direct mode if built with MeegoTouch and keeps track of the state of the VKB (opened/closed).

It is based on the Qt VKB patch in bug 582371.
Attachment #461434 - Flags: review?(doug.turner)
Blocks: 583150
Blocks: 583286
Blocks: 583341
Depends on: 583039
Comment on attachment 461434 [details] [diff] [review]
Patch to improve VKB support in MeegoTouch/Maemo6

changing reviewer on behalf of doug. Added dependency to build-flags
Attachment #461434 - Flags: review?(doug.turner) → review?(romaxa)
Updated patch to use new #define name as changed in 583039
Attachment #461434 - Attachment is obsolete: true
Attachment #462105 - Flags: review?(romaxa)
Attachment #461434 - Flags: review?(romaxa)
No longer depends on: 583039
Comment on attachment 462105 [details] [diff] [review]
Patch changed to use new #define name

comment as to what gKeyboardOpen is suppose to do..  Maybe just add "There is no clear API in Pure QT about how to get OPEN/CLOSED vkb state".

drop the changes to MozQWidget::inputMethodQuery
Attachment #462105 - Flags: review?(romaxa) → review-
Removed the nearly duplicated code in inputMethodQuery() and added a comment about the global variable.
Attachment #462105 - Attachment is obsolete: true
Attachment #462232 - Flags: review?(doug.turner)
No longer blocks: 583150
Attachment #462232 - Flags: review?(doug.turner) → review+
http://hg.mozilla.org/mozilla-central/rev/c804ab5d92d1
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.