Closed Bug 583154 Opened 14 years ago Closed 14 years ago

If you don't comment while setting the work_time (Hours Worked) field, you get an empty comment in bugmails

Categories

(Bugzilla :: Creating/Changing Bugs, defect)

3.7.2
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 4.0

People

(Reporter: LpSolit, Assigned: LpSolit)

References

Details

(Keywords: regression)

Attachments

(1 file)

This is what I get in bugmail when not commenting when adding some time to the work_time field:

--- Comment #6 from Fred <LpSolit@netscape.net> ---


-- Configure bugmail: https://localhost/bugzilla-pg/userprefs.cgi?tab=email 

Not very helpful. The comment should be skipped in this case, meaning that users who are not in the timetracking group should get no bugmail at all if no other visible changes occured.
Attached patch patch, v1Splinter Review
Note that I use ->body instead of ->body_full, because 1) body_full is language-dependent, 2) it calls template_inner(), which is slower, and 3) if ->type is true, I don't need to know more about its content.
Assignee: create-and-change → LpSolit
Status: NEW → ASSIGNED
Attachment #467973 - Flags: review?(mkanat)
Comment on attachment 467973 [details] [diff] [review]
patch, v1

Looks good to me.

You could change \S+ to just \S, on checkin, if you want.
Attachment #467973 - Flags: review?(mkanat) → review+
Flags: approval4.0+
Flags: approval+
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/BugMail.pm
Committed revision 7441.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified Bugzilla/BugMail.pm
Committed revision 7382.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: