583204 - return value (if sizeof < 4) is wrong on BIG ENDIAN machine

Status: RESOLVED WORKSFORME

(Core :: js-ctypes, defect)

Description

[Ginn Chen]

The ffi usage is:
For smaller return value sizes, the ffi_arg or ffi_sarg integral type must be used to hold the return value.

so if the return value is int8_t, we should do
int8_t rv = *(ffi_arg*)result_address;

But currently we do
int8_t rv = *(int8_t*)result_address;

It doesn't matter if it is LITTLE ENDIAN.
But it is not portable to BIG ENDIAN machine, e.g. SPARC.

There're several places in ConvertToJS().
We need to do the cast if data is from ffi_call().

Maybe we can do a trick in FunctionType::Call().

Comment 1

[[e-mail]]

What build? I fixed this on tracemonkey (not sure if it's merged to mc yet) a week ago or so.

Comment 2

[Ginn Chen]

mozilla-central, I will try tracemonkey.

Comment 3

[Ginn Chen]

confirm fixed on latest mozilla-central

Thanks!