583215 - tab drag/drop arrow does not disappear at mouse button release

Status: VERIFIED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[tonda kavalec]

User-Agent:       Opera/9.80 (Windows NT 5.1; U; es-LA) Presto/2.6.30 Version/10.61
Build Identifier: Mozilla/5.0 (Windows; Windows NT 5.1; rv:2.0b3pre) Gecko/20100729 SeaMonkey/2.1a3pre

chetzilla related bug

Reproducible: Always

Steps to Reproduce:
1. open a few chanels
2. change their order by dragging it to a new position
3. look at the small violet arrow
Actual Results:  
after releaing mouse, the small arrow is still visible

Expected Results:  
after releaing mouse, the small arrow should disappear

Comment 1

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:2.0b2pre) Gecko/20100701 Lightning/1.1a1pre SeaMonkey/2.1a3pre - Build ID: 20100701101320
Chatzilla 0.9.86

I thought I had reported this but I cannot find it back. Here the arrow (which, in my motif, is green) stays put after drop until I do another drag.

Comment 2

[tonda kavalec]

yes, this is what i tried to describe. Could you confirm in classic theme? I use Modern.

Comment 3

[Tony Mechelynck [:tonymec]]

(In reply to comment #2)
> yes, this is what i tried to describe. Could you confirm in classic theme? I
> use Modern.

I use EarlyBlue (a theme by Robert Kaiser aka Kairo, not distributed with SeaMonkey) and the Chatzilla Light-Faces motif, 6th from top at http://chatzilla.hacksrus.com/motifs/

You can easily check the Classic theme (if you think there could be a difference, I don't) by selecting "SeaMonkey Default Theme" in the addons manager (or in View => Apply Theme) then restarting SeaMonkey. In any case your SeaMonkey version is more recent than mine (but IIUC your Chatzilla version is the same, 0.9.86, and that's what counts).

Comment 4

[tonda kavalec]

Yes, the same problem in Classic theme.

Comment 5

[Glen Mailer]

It would appear this is related to a gecko change, can you identify in which build it previously worked correctly?

Comment 6

[Tony Mechelynck [:tonymec]]

(In reply to comment #5)
> It would appear this is related to a gecko change, can you identify in which
> build it previously worked correctly?

I don't remember ever seeing it working correctly. If it did, I think it would have been Gecko 1.8.1.x or earlier.

Comment 7

[tonda kavalec]

Works in 2.0.6_ Mozilla/5.0 (Windows; U; Windows NT 5.1; es-AR; rv:1.9.1.11) Gecko/20100701 SeaMonkey/2.0.6

Comment 8

[Tony Mechelynck [:tonymec]]

Yeah, I was too pessimistic. SeaMonkey was never built on Gecko 1.9.2. Seems the problem happened between 1.9.1(.11) and 2.0b2pre. I'll try to find the oldest 1.9.3 build for comparison...

Comment 9

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20091001 SeaMonkey/2.1a1pre
ChatZilla 0.9.85
no bug

Comment 10

[Tony Mechelynck [:tonymec]]

the same as in comment #9, with cZ 0.9.86, also no bug, let's try more recent...

Comment 11

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a5pre) Gecko/20100510 SeaMonkey/2.1a1
ChatZilla 0.9.86
has the bug

Comment 12

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20100120 SeaMonkey/2.1a1pre
ChatZilla 0.9.86
no bug

Comment 13

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a3pre) Gecko/20100315 SeaMonkey/2.1a1pre
ChatZilla 0.9.86
has the bug

Comment 14

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a2pre) Gecko/20100217 SeaMonkey/2.1a1pre
ChatZilla 0.9.86
has the bug

Comment 15

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20100204 SeaMonkey/2.1a1pre
cZ 0.9.86
has the bug

Comment 16

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20100128 SeaMonkey/2.1a1pre
cZ 0.9.86
no bug

Comment 17

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20100201 SeaMonkey/2.1a1pre
no bug

Comment 18

[Tony Mechelynck [:tonymec]]

Finally!
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20100202 SeaMonkey/2.1a1pre
has bug

Summary:
Build ID: 20100201003629 bad
Build ID: 20100202020246 good

Comment 19

[Tony Mechelynck [:tonymec]]

oops! I meant:
20100201003629 good
20100202020246 bad

Comment 20

[Ian Neal]

m-c http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2010-02-01+00%3A36%3A29&enddate=2010-02-02+02%3A02%3A46
c-c http://hg.mozilla.org/comm-central/pushloghtml?startdate=2010-02-01+00%3A36%3A29&enddate=2010-02-02+02%3A02%3A46

Comment 21

[Tony Mechelynck [:tonymec]]

changeset 653a6ad047ba for bug 541520 "don't fire dragleave on successful drop, but do fire it when drop fails or is cancelled," sounds suggestive

Comment 22

[tonda kavalec]

Thank you for the work!

Comment 23

[Tony Mechelynck [:tonymec]]

(In reply to comment #22)
> Thank you for the work!

No prob. Just a question of knowing where ( releases.mozilla.org and ftp.mozilla.org ) to get the binaries for a dichotomy search. :-) Then Ian constructed the search URL from what I'd found (thanks Ian). :-)

Comment 24

[Glen Mailer]

Relevant portions of ChatZilla code are:
http://hg.mozilla.org/chatzilla/file/ca24ef809133/xul/content/static.js#l3824
http://hg.mozilla.org/chatzilla/file/ca24ef809133/xul/content/chatzilla.xul#l97

Looks to me like tabsDropObserver.onDrop needs to either call tabsDropObserver.onDragExit or just set client.tabDragBar.collapsed = true;

Comment 26

[James Ross]

Attachment: Make sure we hide the DnD arrow on drag-end

Comment 27

[James Ross]

http://hg.mozilla.org/chatzilla/rev/2d48a4cd7890

Comment 28

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; Linux x86_64; rv:2.2a1pre) Gecko/20110328 Firefox/4.2a1pre SeaMonkey/2.2a1pre ID:20110328114322

The latest nightly was built too soon, but the ChatZilla built into this tinderbox-build of SeaMonkey does not exhibit the bug anymore.

=> VERIFIED.