58323 - after shift delete local msg can't load another msg

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P1)

Description

[David :Bienvenu]

I shift deleted a msg in my pop inbox. After that, I couldn't load any messages
in my inbox.

Comment 1

[David :Bienvenu]

If this is reproducible, we should consider fixing it.

Comment 2

[David :Bienvenu]

Attachment: proposed fix

Comment 3

[David :Bienvenu]

OK, I've attached the fix. The problem was that in the shift delete case, we
weren't sending a notification to the front end that the delete/move had
finished (which it does immediately). For some reason, I changed the check that
fails here (if (!ismove) to if (ismove)) a couple months ago. I think I should
have left it alone. I've tried various combinations of shift delete, normal
delete, drag drop moves (which was the bug I was trying to fix in the first
place), etc, and they all seem to work.

Comment 4

[David :Bienvenu]

I think at the time I introduced this bug, I was trying to fix cross-imap server
move/copy (though I can't say for sure). Anyway, I tried that, and it still
works as well, not that this routine should be involved at all during cross-imap
server moves.

Comment 5

[selmer (gone)]

marking [rtm need info] so you can go to [rtm+] once the reviews are in.

Could this bug have caused my problems where the thread pane never updates after
I shift-delete a bunch of messages?  (I have another bug on that against trees.)

Comment 6

[David :Bienvenu]

only if the folders you saw this bug in were local folders, and you did a
shift-delete in them. This bug only affects local folders.

Comment 7

[Scott MacGregor]

sr=mscott

Comment 8

[David :Bienvenu]

great, thanks, so if I can just get an r= from jeff or someone...

To test, you should try the following and make sure the right things happen,
including the subsequent message getting loaded after the delete/move (if
appropriate), and that you're still able to select other messages in the source
folder. (the code change shouldn't affect all of these, especially when the
source folder is an imap folder, but just to be on the safe side...)

1. Delete a msg in a local folder
2. shift delete a msg in a local folder
3. move a local msg to another local folder (with msg menu and drag+drop).
4. move a local msg to an imap folder (with msg menu and drag+drop)
5. copy a local msg to another local folder(with msg menu and drag+drop)
6. move an imap msg across servers

Comment 9

[(not reading, please use [e-mail] instead)]

r=sspitzer

cc'ing alecf for the sr, since I see he is online.

Comment 10

[David :Bienvenu]

got an sr from mscott. just need a + and then a ++ from pdt.

Comment 11

[David :Bienvenu]

changing priority - don't want to get missed by potential queries.

Comment 12

[(not reading, please use [e-mail] instead)]

based on selmer's comment, "marking [rtm need info] so you can go to [rtm+] once
the reviews are in."

marking rtm+.

Comment 13

[Jim Roskind]

This bug is in candidate limbo.  We will reconsider this fix once we have a 
candidate in hand, but we can't take this fix before then.

Please go ahead and check this into the trunk asap.  Anticipate that we'll 
probably mark this double plus on Monday, as we land a slew of limbo bugs.

Comment 14

[David :Bienvenu]

fix checked into trunk.

Comment 15

[Phil Peterson]

PDT marking [rtm++]. This bug is now out of limbo and approved for checkin to
the branch. Please check in ASAP.

Comment 16

[David :Bienvenu]

fix checked in.

Comment 17

[jefft]

Verified fixed on branch.

Comment 18

[jefft]

Adding vtrunk.

Comment 19

[Sheela Ravindran]

verified on buildid:2000121104 for WinNT