Closed Bug 583232 Opened 14 years ago Closed 14 years ago

Add rewrapping to jsapi.h

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Version:
Other Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
blocking2.0 --- beta5+

People

(Reporter: jorendorff, Assigned: jorendorff)

References

Details

(Whiteboard: [compartments] fixed-in-tracemonkey)

Attachments

(1 file)

v1
1.56 KB, patch
gal
: review+
Details | Diff | Splinter Review
Attached patch v1 — — Splinter Review 
We might as well check this stuff in.
Attachment #461528 - Flags: review?(gal)
Blocks: compartments
Comment on attachment 461528 [details] [diff] [review]
v1

Not sure we need this and not sure I like the obj* version of it, but also not opposed strongly enough to stop you.
Attachment #461528 - Flags: review?(gal) → review+
What happens if there are other refs smeared around the compartment's stack and heap that need to refer to the wrapper now? The objp in/out param won't handle that. Not sure it matters, though.

For something like an MT wrapper it does, so that's why the wrapper becomes the object (swaps guts, assuming its identity).

/be
blocking2.0: --- → beta5+
Whiteboard: [compartments]
Assignee: general → jorendorff
Assignee: jorendorff → sayrer
http://hg.mozilla.org/tracemonkey/rev/3fb80571a8cf
Assignee: sayrer → jorendorff
Whiteboard: [compartments] → [compartments] fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/3fb80571a8cf
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
http://hg.mozilla.org/tracemonkey/rev/9eaff50687a3 is a followup to fix the Rewrap{Object,Value} -> Wrap{Object,Value} confusion that was landed here.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: