583292 - Assert Property error in testUndoTabFromContextMenu.js (default)

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Aaron Train [:aaronmt]]

MODULE: firefox/testSessionStore/     
TEST: testUndoTabFromContextMenu.js
FAIL: Controller.assertProperty(ID: context_undoCloseTab) : true == false
BRANCH: default

With the recent changes in trunk
http://hg.mozilla.org/mozilla-central/rev/a68fa21f86b2 @ bug 580956

The test needs updating to check to disabled instead of hidden

Comment 1

[Aaron Train [:aaronmt]]

Attachment: Patch v1 - From 'hidden' to 'disabled'

Comment 2

[u279076]

Comment on attachment 461586 [details] [diff] [review]
Patch v1 - From 'hidden' to 'disabled'

>+const LOCAL_TEST_FOLDER = collector.addHttpResource('../test-files/');
> 

Let's use a LOCAL_TEST_PAGE constant here to contain the URL:
const LOCAL_TEST_PAGE = LOCAL_TEST_FOLDER + "tabbedbrowsing/openinnewtab_target.html?id=";

>   // Open 3 tabs with pages in the local test folder
>   for (var i = 0; i < 3; i++) {
>-   controller.open(localTestFolder + 
>+   controller.open(LOCAL_TEST_FOLDER + 
>                    'tabbedbrowsing/openinnewtab_target.html?id=' + i);

Then the loop simply becomes:
controller.open(LOCAL_TEST_PAGE + i);

Comment 3

[Aaron Train [:aaronmt]]

Attachment: Patch v1.1 - From 'hidden' to 'disabled' - fixes

Comment 4

[u279076]

Comment on attachment 464247 [details] [diff] [review]
Patch v1.1 - From 'hidden' to 'disabled' - fixes

Looks good.  Over to Henrik for followup.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Comment on attachment 464247 [details] [diff] [review]
Patch v1.1 - From 'hidden' to 'disabled' - fixes

>+const LOCAL_TEST_PAGE = LOCAL_TEST_FOLDER + 
>+      "tabbedbrowsing/openinnewtab_target.html?id=";

Nit: Please indent that correctly.

Otherwise r=me.

Comment 6

[u279076]

(In reply to comment #5)
> Comment on attachment 464247 [details] [diff] [review]
> Patch v1.1 - From 'hidden' to 'disabled' - fixes
> 
> >+const LOCAL_TEST_PAGE = LOCAL_TEST_FOLDER + 
> >+      "tabbedbrowsing/openinnewtab_target.html?id=";
> 
> Nit: Please indent that correctly.
> 
> Otherwise r=me.

I'll correct that prior to check-in.

Comment 7

[u279076]

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/79286a91d333 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/096f3f46b292 (mozilla1.9.2)
http://hg.mozilla.org/qa/mozmill-tests/rev/fb12391d7c9b (mozilla1.9.1)

Comment 8

[Aaron Train [:aaronmt]]

(In reply to comment #7)
> Landed:
> http://hg.mozilla.org/qa/mozmill-tests/rev/79286a91d333 (default)
> http://hg.mozilla.org/qa/mozmill-tests/rev/096f3f46b292 (mozilla1.9.2)
> http://hg.mozilla.org/qa/mozmill-tests/rev/fb12391d7c9b (mozilla1.9.1)

This is a (default) fix as indicated in comment #0. Please back out (mozilla1.9.2) and (mozilla1.9.1).

Comment 9

[u279076]

Backed-out:
http://hg.mozilla.org/qa/mozmill-tests/rev/cf4a134c0d8d (mozilla1.9.2)
http://hg.mozilla.org/qa/mozmill-tests/rev/3e2f0d88fb09 (mozilla1.9.1)

Sorry for the confusion.  I thought this was being backported.  In the future, if the patch is for default-only, please indicate it.  If the patch needs to be backported, please indicate that as well.

Thanks.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.