583293 - Add some timer based workaroundto VKB popup for strange websites

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[Steffen Imhof]

Attachment: Patch to popup the VKB with a small delay to prevent too fast switches

There are websites (like gmail.com) that focus some editable object for a short while when switching page content.

This leads to the somewhat undesirable result, that the VKB pops up shortly and immediately is closed again. While this is working as designed it is still annoying.

The attached patch tries to work around this by not immediately opening the VKB but instead starting a timer and canceling the popup if the VKB is closed again in the meantime.

Currently the timer value is 300ms, but can be changed by setting the environment variable MOZ_QT_VKBTIMEOUT.

Comment 1

[Jeremias Bosch (:jbos)]

Comment on attachment 461589 [details] [diff] [review]
Patch to popup the VKB with a small delay to prevent too fast switches

Change review on behalf of doug

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 461589 [details] [diff] [review]
Patch to popup the VKB with a small delay to prevent too fast switches


>+static bool gPendingVKBOpen = false;

please add a comment.

>+        requestVKB(0); //means the application requested the VKB during but
>+                       //did not manage to open it because there was no focused window yet

C style comments please.  80 col too, ftw.


>+            QTimer::singleShot( aTimeout, this, SLOT(showVKB()));

no space between ( and aTimeout.




>+            int timevalue = 300;
>+            const char* timeout = getenv("MOZ_QT_VKBTIMEOUT");
>+            if (timeout) {
>+                timevalue = atoi(timeout);

change the timeout to a mozilla preference.  jim can help you with fixing up the android side of things (which also should use a preference)

Comment 3

[Steffen Imhof]

(In reply to comment #2)
> >+        requestVKB(0); //means the application requested the VKB during but
> >+                       //did not manage to open it because there was no focused window yet
> 
> C style comments please.  80 col too, ftw.

The whole Qt port has C++ style comments inside the code, so I would like to keep it that way, just using its own line for it. And staying in the 80 col boundary of course.


> change the timeout to a mozilla preference.  jim can help you with fixing up
> the android side of things (which also should use a preference)

Jim, do you already have a bug number for the Android stuff? Or a name of the preference? If not, how about "ui.vkb.open.delay"?

Comment 4

[Steffen Imhof]

Attachment: New version of the patch (review comments)

I updated the patch to address the review comments and for now I used the name I proposed for the preference (should be easy to change if needed).

Comment 5

[Doug Turner (:dougt)]

Comment on attachment 462487 [details] [diff] [review]
New version of the patch (review comments)

i'll fix the spelling error in the comment, and drop the NS_WARNING if the pref isn't set.

Comment 6

[Steffen Imhof]

(In reply to comment #5)
> Comment on attachment 462487 [details] [diff] [review]
> New version of the patch (review comments)
> 
> i'll fix the spelling error in the comment, and drop the NS_WARNING if the pref
> isn't set.

Thanks.

Comment 7

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/87df83f1ce2c