583306 - Save and restore tab hidden state with sessionstore

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Ian Gilman [:iangilman]]

If the user quits with several tabs hidden, the browser should reopen in that same state.

Adding hidden should be similar to this patch, where pinned was added:

http://hg.mozilla.org/mozilla-central/rev/8e8042431c86

Comment 1

[Ed Lee :Mardak]

The hidden state of the tab is accessible from (xul:tab).hidden both as a js property and dom attribute.

Comment 2

[(no longer active)]

So, with a patch that fixes this bug, if I have multiple groups and show one of them and restart Firefox, I should get only the tabs from that group, right?

Comment 3

[Ed Lee :Mardak]

Only the visible set of tabs from last time will be visible on restart. The other tabs will be hidden (and potentially delayed loading!)

Comment 4

[Ian Gilman [:iangilman]]

In other words, yes. 

It should be noted that we'll want to apply this patch to Mardak's tabcandy-central branch (as well as ultimately to mozilla-central). Mardak's branch is at: 

http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/

Comment 5

[Ian Gilman [:iangilman]]

I believe ehsan is going to take this; actually assigning it so it's official.

Comment 6

[(no longer active)]

As far as I've tested this patch, it's working correctly.

http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/af9bf0eb47e7

Comment 7

[Ian Gilman [:iangilman]]

Looks beautiful!

Comment 8

[Ed Lee :Mardak]

Raymond, are these changes still necessary now that tabs are hidden if they were previously hidden?

http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/df9bbe8b6d78

Comment 9

[Ed Lee :Mardak]

http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/64e4cce311e8
Backout df9bbe8b6d78 now that bug 583306 is fixed.

Comment 10

[Raymond Lee [:raymondlee]]

(In reply to comment #8)
> Raymond, are these changes still necessary now that tabs are hidden if they
> were previously hidden?
> 
> http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/df9bbe8b6d78

Yeah, we don't need this anymore.

Comment 11

[(no longer active)]

Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".