Closed Bug 583318 Opened 13 years ago Closed 13 years ago

MACOSX_DEPLOYMENT_TARGET should match SDK by default

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking2.0 final+)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
blocking2.0 --- final+

People

(Reporter: jaas, Assigned: jaas)

References

Details

Attachments

(2 files, 1 obsolete file)

fix v2.0
1.14 KB, patch
ted
: review+
Details | Diff | Splinter Review
fix v2.0 (export for check-in)
1.19 KB, patch
Details | Diff | Splinter Review 
We require the 10.6 SDK to build 64-bit on Mac OS X. If you don't specify --enable-macos-target, which sets MACOSX_DEPLOYMENT_TARGET, then it gets set to 10.5 which is incorrect.

If someone is building a 32-bit build against the 10.6 SDK then MACOSX_DEPLOYMENT_TARGET should default to 10.6. Right now it would still default to 10.5.
This will often result in unexpectedly misconfigured builds, especially since 2.0 includes 64-bit support which requires the 10.6 SDK. I think this should block 2.0.
blocking2.0: --- → ?
Looks like this is a problem for our 64-bit nightly builds, they are using the default 10.6 SDK but because they don't specify an OS target they are targeting 10.5.
So do you want to set --enable-macos-target in the tinderbox builds, or fix configure, or both ?
We should probably use --enable-macos-target until this bug gets fixed, it'll just become unnecessary when this is fixed.
Blocks: 586832
Attached patch fix v1.0 (obsolete) — — Splinter Review 
If we simply stop defining MACOSX_DEPLOYMENT_TARGET unless one is specified in the mozconfig we should be fine. Anyone who wants to target an OS that is older than the SDK in use can make it happen explicitly in their mozconfig.
Assignee: nobody → joshmoz
Attachment #465500 - Flags: review?(ted.mielczarek)
Attached patch fix v2.0 — — Splinter Review 
Alternatively we could do something like this, which is just an improvement on our current strategy.
Attachment #465503 - Flags: review?(ted.mielczarek)
blocking2.0: ? → final+
Comment on attachment 465503 [details] [diff] [review]
fix v2.0

This is more akin to our WIN32_TARGET setup, and should help people ensure that they don't accidentally use 10.6-only features while we're still supporting 10.5 without having to manually specify the 10.5 SDK.
Attachment #465503 - Flags: review?(ted.mielczarek) → review+
Attachment #465500 - Flags: review?(ted.mielczarek) → review-

        Attachment #465500 -
        Attachment is obsolete: true

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/9f193e1683ee
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED

    
  
Blocks: 589438

    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.