583328 - IE: JS error on questions pages

Status: VERIFIED FIXED

(support.mozilla.org :: Questions, task)

Description

[Rebecca Billings [:rbillings]]

On multiple versions of IE, there is a JS error displayed if the user clicks 'ask this' with a blank field.

1. Open IE 7/8> log in
2. Go to Ask Question page:
https://support-stage.mozilla.com/en-US/questions/new?product=home&category=i1
3. Without Entering question on textbox, click on Ask button


Error: Line: 9
Char:9
Error: Expected identifier, string or number
code: 0
url:https://support-stage.mozilla.com/en-US/questions/new?product=desktop&category=d6&search=

Comment 1

[James Socol [:jsocol, :james]]

I was getting this error on most/all questions pages, not just by entering a blank question. Paul had the rash audacity to end lists with commas, which no other browser thinks is a problem.

I found two. Patch incoming.

Comment 2

[James Socol [:jsocol, :james]]

http://github.com/jsocol/kitsune/commit/1a509dde5a8dc1f2cb0bb25944fbb905e4fd40ed

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using IE 7 and IE 8; didn't test IE 6.  We'll do so as a final pass (in addition to ongoing).