Closed Bug 583362 Opened 14 years ago Closed 14 years ago

Opening site panel does not make form assistant disappear

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
major

Tracking

(fennec2.0b1+)

RESOLVED WONTFIX
Tracking Status
fennec 2.0b1+ ---

People

(Reporter: aakashd, Assigned: fabrice)

Details

Attachments

(2 obsolete files)

Build Id:
Mozilla/5.0 (Android; U; Linux armv71; en-US; rv:2.0b2pre) Gecko/20100730 Namoroka/4.0b3pre Fennec/2.0a1pre

Steps to Reproduce:
1. Go to bugzilla.mozilla.org
2. Click on the search field to bring up the form assistant
3. Click on the favicon to open the site panel

Actual Results:
The form assistant stays visible.

Expected Results:
The form assistant should disappear since I clicked outside of the bar.
tracking-fennec: ? → 2.0b1+
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → fabrice
Attachment #464403 - Flags: review?(mark.finkle)
Aakash, out of curiosity, is this android only or do you see it on maemo as well?
Brad, I've seen it on desktop linux & maemo
OS: Android → All
Hardware: ARM → All
I don't like how the code to hide any possible popup is creeping across many files and functions. Centralizing this behavior would be cleaner. Maybe a followup bug.

Also, are we sure the Form Assistant should be hidden when we display the sitemenu? On desktop Firefox the Find bar stays open if I open other UI, for example.
Upon more thought, I don't think the Form Assistant should close when opening the Site Menu. The Form Assistant is glued to the content. It pans with the UI. Tapping in the content should, and does close the Form Assistant. Executing another content-based command, like Find-in-Page should close the Form Assistant.

The Site Menu itself does not execute a command, so we shouldn't close the Form Assistant. If the user does execute a command from the menu, the Form Assistant should close.

WONTFIXing this bug
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WONTFIX
Attachment #464403 - Attachment is obsolete: true
Attachment #464403 - Flags: review?(mark.finkle)
(In reply to comment #6)
> Created attachment 521418 [details] [diff] [review]
> Add gczeal function for xpcshell content processes.

Wrong bug?
Comment on attachment 521418 [details] [diff] [review]
Add gczeal function for xpcshell content processes.

Quite!
Attachment #521418 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: