58342 - "Import Identity" is hard coded in nsOutlookCompose.cpp and nsEudoraCompose.cpp

Status: NEW

(MailNews Core :: Import, defect)

Description

[(not reading, please use [e-mail] instead)]

"Import Identity" should be in a string bundle.

Comment 1

[tonyr]

I suspect this is also in nsOutlookCompose.cpp

Comment 2

[(not reading, please use [e-mail] instead)]

yeah, it's in both.

updating summary.

(can the common code be shared?)

Comment 3

[(not reading, please use [e-mail] instead)]

fixing spelling mistake in summary.

Comment 4

[Cindy Roberts]

Marking nsbranch- as it was decided in the August bug triage that we wouldn't
have enough time in eMojo to fix this.  Let's revisit for MachV.

Comment 5

[elaineking]

removed keyword nsbranch since it now has nsbranch-, per pdt mtg.

Comment 6

[Michele Carlson]

Ji - can you have someone on your team take a look at this bug. Is it still
valid? Would be nice to have this one fixed for Machv. thanks

Comment 7

[ji]

Hi Seth, where should I check for this?

Comment 8

[Jaime Rodriguez, Jr.]

is this something we need for MachV, or can it be targetted for M1.0.1? If its
needed, we should no,minate it as nsbeta1.

Comment 9

[rchen]

Seth, can you help ji to identify the problem? 

The string is in nsOutlookCompose.cpp and nsEudoraCompose.cpp. How do users 
bring it up to UI? Please advise. 

Comment 10

[rchen]

Jag, is the string visible to the users? If yes, can you advise how to bring it 
up to UI? Thanks. 

No respond from [e-mail].
Reassigned to [e-mail], since you have the last touch.

Comment 11

[(not reading, please use [e-mail] instead)]

jag's not the proper owner for this.

over to cavin.

note, I don't think this string ever shows up in the UI.

if that's the case, we should add a comment to the code

// don't worry about this, it never shows up in the UI.

cavin, can you find out if this is ever visible to the user or not?

Comment 12

[rchen]

Since it never shows in UI, remove l12y keyword.

Comment 13

[Michael Buckland]

Discussed in 2/25 bug meeting with Mktng, PjM, Engineering.  Decision to minus
and  1.2.

Comment 14

[Andreas Kunz]

Adding the _current_ lxr link for the first occurrence to the URL field:
http://lxr.mozilla.org/seamonkey/source/mailnews/import/outlook/src/nsOutlookCompose.cpp#217
the other one is
http://lxr.mozilla.org/seamonkey/source/mailnews/import/eudora/src/nsEudoraCompose.cpp#224
- just for reference...

Comment 15

[Mike Cowperthwaite]

Not i18n.  Those URL's in comment 14 get pretty close to the offending code, I guess import hasn't changed much.

Comment 16

[:aceman]

I'll take this to see if anything is actually needed after bug 318495.