58344 - death to iostreams in htmlparser!

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect, P3)

Description

[Christopher Blizzard (:blizzard)]

htmlparser is the only place where iostreams are being used.  They should be
pulled out.

Comment 1

[Christopher Blizzard (:blizzard)]

Attachment: patch

Comment 2

[Christopher Blizzard (:blizzard)]

By the way, libhtmlparser.so gets 120k smaller on my machine with this patch.

Comment 3

[Christopher Blizzard (:blizzard)]

Did either of you get to look at this?

Comment 4

[harishd]

Most of the changes look staightforward, however, I couldn't understand why
logging sink is out of nsParserFarctory?  Enlighten me please..

Comment 5

[rickg]

I'm in the midst of tracking down a potential RTM bug, but I'll look at this 
next. (Hopefully by tomorrow.)

Comment 6

[Christopher Blizzard (:blizzard)]

Attachment: patch 2

Comment 7

[Christopher Blizzard (:blizzard)]

I've uploaded a new patch that fixes the problem that harishd pointed out.
Also, this one disables prstrm.cpp on windows.  I think I need someone on the
mac to tell me how to turn of the build on that platform.

Comment 8

[rickg]

Chris: My tree is so vastly different that your patch isn't working. I'm 
fixing it up manually now, and I'll let you know how it goes.

Comment 9

[rickg]

Ok, merge complete. I'll do some testing next. 

Comment 10

[Christopher Blizzard (:blizzard)]

Rick, any luck with testing?

Comment 11

[rickg]

I'm testing now, and will likely land this code within a week along with a bunch 
of my other changes.

Comment 12

[tor]

Rick, any news regarding when your changes will hit the tree?

Comment 13

[rickg]

Delay's, all of em. Now I'm just waiting to confirm that no problems will be 
created for the Mac build. I'm talking to a mac guy about it later today.

Comment 14

[Christopher Blizzard (:blizzard)]

la la la

two month anniversary coming up on this patch.

Comment 15

[harishd]

Attachment: Revised patch [ in sink with Vidur's recent parser changes ]

Comment 16

[rickg]

harish: I've already got the patch, and I'm trying to land it this week. Please 
dont check this in on top of me.

Comment 17

[tor]

We've been hearing the "checking in soon" story for two months now.
What's the holdup?

Comment 18

[rickg]

Classic story; Holidays got in the way. But I'm testing the top 100 now, with a 
checkin slated for tomorrow after my meetings. 

Comment 19

[rickg]

The code for this was landed last week. 

Comment 20

[Christopher Blizzard (:blizzard)]

This was checked in.

Comment 21

[Peter "jag" Annema]

Apparantly part of the patch to nsToken.h didn't land. The #include <iostream.h>
is still in there. Reopening bug, attaching patch, going through the motions.
Mozilla compiles fine without the include.

Comment 22

[Peter "jag" Annema]

Attachment: [patch] You missed a spot

Comment 23

[Brendan Eich [:brendan]]

r/sr=[e-mail], this can go in ASAP.

/be

Comment 24

[Peter "jag" Annema]

Checked in.

Comment 25

[bsharma]

updated qa contact.

Comment 26

[bsharma]

Verified on:
build: 2001-06-04-09-Mtrunk
platform: WinNT

Marking it verified as per above developer comments.